From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75349C43334 for ; Mon, 6 Jun 2022 02:42:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95B458D0003; Sun, 5 Jun 2022 22:42:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90A818D0002; Sun, 5 Jun 2022 22:42:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CFF78D0003; Sun, 5 Jun 2022 22:42:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6F32D8D0002 for ; Sun, 5 Jun 2022 22:42:16 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3CB274F9 for ; Mon, 6 Jun 2022 02:42:16 +0000 (UTC) X-FDA: 79546261872.07.113A580 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf03.hostedemail.com (Postfix) with ESMTP id DD4862004E for ; Mon, 6 Jun 2022 02:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654483335; x=1686019335; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=kUhaSosvvsxHejtDinruxD4IAiNMtBhJaEMaIQ8BugY=; b=BeCLdTbX9mrYTuyE4E4BadA5Li8S0LwX+gxXC7RbBNQnHgyiObBKfRLu KH9qKR3hDUKurnIM/0lyYyYQ43tpgVQty+zso+7BtHuEifuRQQ8nidsFi +g9JIHd6vQ2LEJcwxEGOuOEwlR8wTbz8AqxIL9M1r0/h9gwZ3DJFGEYk6 CT62la3XsxAclgUWjC+ivjYOsFj5M73thw/XNAu9iOzoAUDGMXPSNWQGw wFUJul5QgnENUhy3VdUFoT6Weum22hW2WjiqjUOSRxJH0PQTLc7iLG+qm ZEpnLMWO3DqtoJbu+5HdMGITFgE3UJkfaDhDB6JHqO/WP/kn73rsWc/vj w==; X-IronPort-AV: E=McAfee;i="6400,9594,10369"; a="264380249" X-IronPort-AV: E=Sophos;i="5.91,280,1647327600"; d="scan'208";a="264380249" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2022 19:42:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,280,1647327600"; d="scan'208";a="531934898" Received: from lkp-server01.sh.intel.com (HELO 60dabacc1df6) ([10.239.97.150]) by orsmga003.jf.intel.com with ESMTP; 05 Jun 2022 19:42:04 -0700 Received: from kbuild by 60dabacc1df6 with local (Exim 4.95) (envelope-from ) id 1ny2gt-000CQT-NX; Mon, 06 Jun 2022 02:42:03 +0000 Date: Mon, 6 Jun 2022 10:41:26 +0800 From: kernel test robot To: Zach O'Keefe , Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , Peter Xu , Rongwei Wang , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org Cc: kbuild-all@lists.01.org, Andrea Arcangeli , Andrew Morton , Linux Memory Management List , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin Subject: Re: [PATCH v6 03/15] mm/khugepaged: add struct collapse_control Message-ID: <202206060911.I8rRqGwC-lkp@intel.com> References: <20220604004004.954674-4-zokeefe@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220604004004.954674-4-zokeefe@google.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DD4862004E X-Stat-Signature: qe76ad8ckmsyptyabydqi4iiw553mghr X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BeCLdTbX; spf=none (imf03.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1654483318-878132 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Zach, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-userspace-hugepage-collapse/20220606-012953 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20220606/202206060911.I8rRqGwC-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-1) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/d87b6065d6050b89930cca0814921aca7c269286 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Zach-O-Keefe/mm-userspace-hugepage-collapse/20220606-012953 git checkout d87b6065d6050b89930cca0814921aca7c269286 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): mm/khugepaged.c: In function 'khugepaged': >> mm/khugepaged.c:2284:1: warning: the frame size of 4160 bytes is larger than 2048 bytes [-Wframe-larger-than=] 2284 | } | ^ vim +2284 mm/khugepaged.c b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2261 b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2262 static int khugepaged(void *none) b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2263 { b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2264 struct mm_slot *mm_slot; d87b6065d6050b Zach O'Keefe 2022-06-03 2265 struct collapse_control cc = { d87b6065d6050b Zach O'Keefe 2022-06-03 2266 .last_target_node = NUMA_NO_NODE, d87b6065d6050b Zach O'Keefe 2022-06-03 2267 }; b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2268 b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2269 set_freezable(); b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2270 set_user_nice(current, MAX_NICE); b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2271 b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2272 while (!kthread_should_stop()) { d87b6065d6050b Zach O'Keefe 2022-06-03 2273 khugepaged_do_scan(&cc); b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2274 khugepaged_wait_work(); b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2275 } b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2276 b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2277 spin_lock(&khugepaged_mm_lock); b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2278 mm_slot = khugepaged_scan.mm_slot; b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2279 khugepaged_scan.mm_slot = NULL; b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2280 if (mm_slot) b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2281 collect_mm_slot(mm_slot); b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2282 spin_unlock(&khugepaged_mm_lock); b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2283 return 0; b46e756f5e4703 Kirill A. Shutemov 2016-07-26 @2284 } b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2285 -- 0-DAY CI Kernel Test Service https://01.org/lkp