From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3841C433EF for ; Mon, 6 Jun 2022 07:12:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A8278D0003; Mon, 6 Jun 2022 03:12:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05B6A8D0002; Mon, 6 Jun 2022 03:12:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8A608D0003; Mon, 6 Jun 2022 03:12:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D83D48D0002 for ; Mon, 6 Jun 2022 03:12:02 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AAE82659 for ; Mon, 6 Jun 2022 07:12:02 +0000 (UTC) X-FDA: 79546941684.23.0F9D382 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf05.hostedemail.com (Postfix) with ESMTP id 04C2110002A for ; Mon, 6 Jun 2022 07:11:23 +0000 (UTC) Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-2f4dfd09d7fso116273747b3.0 for ; Mon, 06 Jun 2022 00:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=FAsSBSY7Wsisoy3/WyKLJttYBWhLnj7t3o8A0ZUkcJM=; b=QQuWsZ1j/7tV4jRVtGGyXr+t5u71dCwAmHzKBGeywSe6u/moa/zY+SsWHXCX214nOB BhprH0ZrUtlDeEM3an2Okonvg/C3LdAnmPA2XXqCaSh2rBpc4gMjTOi4XR/4lCl+v0ln sOp3Szo27ICJjD7zo17IrUK/LLpSPJtno97jFu68WSpmsnY/Ct4Pr8iae4A6KjS8Vfnk 28tYF6gjA89yMONWjyzGZ8CoSLyIGNbXo6gYxb7Mu0KsNLPMaz7MbnjLYEzUZ4nf8lFw x8GXfmj9OXcVihgZ9aAia/DyrA9DAmX4J4HacTUGc6EvLgwOXQPtC7eRFQSil95i+Kdo T1QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=FAsSBSY7Wsisoy3/WyKLJttYBWhLnj7t3o8A0ZUkcJM=; b=yjcy5TshyzsaKD3Of9VjnblMwRONjuvT3zasLWKaelVAF75SEAqwSsjuBW9eQ+Z9wl w1uUrDW4CZPocjjQB9M05NY9dS47itWY8UosfwO53Np13vwRvc+ZQiWTJyHx7wW6+7bp FJMSuNmztmTo7NTMI78L6im8gJBXMHbJw2hubLrorT2anXz/BjUetG+ULiuw2ltyQHjz BB7H/POCgGrI89h8a03mydxaCb3LdE4+ALh5PmXyA+AAlwpW5jsBEji2/CJElKqIBjSR 3Y6gQPcphwaom48UjWwtmOWJliuEa4c/X+gC012S6l3AtIPsHeA43glO3f6j/pamK+XR V5nA== X-Gm-Message-State: AOAM531MP3ENwnu1c25KXlj3WryVNYzBFFJR8wJ/0VrHRiI5x/AbIqzr /WEzhIVxk0rqP1qiUDtphwY66AMoxuSTcg== X-Google-Smtp-Source: ABdhPJxIKHGhLv9rUMq9S3FTBeIeO30cLZ2298g4lAGzXyFm/ocwFPtsLRuVN4At8OR7eYZgs9nwNDNwz35IdQ== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:28b]) (user=shakeelb job=sendgmr) by 2002:a25:250:0:b0:65c:84a1:2db7 with SMTP id 77-20020a250250000000b0065c84a12db7mr24177287ybc.296.1654499521408; Mon, 06 Jun 2022 00:12:01 -0700 (PDT) Date: Mon, 6 Jun 2022 07:11:57 +0000 In-Reply-To: <20220604082209.55174-1-zhengqi.arch@bytedance.com> Message-Id: <20220606071157.vcx4ykadvlbpqlib@google.com> Mime-Version: 1.0 References: <20220604082209.55174-1-zhengqi.arch@bytedance.com> Subject: Re: [PATCH v2] mm: memcontrol: add {pgscan,pgsteal}_{kswapd,direct} items in memory.stat of cgroup v2 From: Shakeel Butt To: Qi Zheng Cc: hannes@cmpxchg.org, roman.gushchin@linux.dev, songmuchun@bytedance.com, mhocko@kernel.org, akpm@linux-foundation.org, corbet@lwn.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 04C2110002A X-Stat-Signature: hcz6c96cxc3q1wry1oozfbszryz4j31y Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=QQuWsZ1j; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of 3waidYggKCKQWLEOIIPFKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--shakeelb.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3waidYggKCKQWLEOIIPFKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--shakeelb.bounces.google.com X-HE-Tag: 1654499483-253179 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 04, 2022 at 04:22:09PM +0800, Qi Zheng wrote: > There are already statistics of {pgscan,pgsteal}_kswapd and > {pgscan,pgsteal}_direct of memcg event here, but now only the > sum of the two is displayed in memory.stat of cgroup v2. > > In order to obtain more accurate information during monitoring > and debugging, and to align with the display in /proc/vmstat, > it better to display {pgscan,pgsteal}_kswapd and > {pgscan,pgsteal}_direct separately. > > Also, for forward compatibility, we still display pgscan and > pgsteal items so that it won't break existing applications. > > Signed-off-by: Qi Zheng > Acked-by: Johannes Weiner > Acked-by: Roman Gushchin > Acked-by: Muchun Song Acked-by: Shakeel Butt