From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD309C433EF for ; Wed, 1 Jun 2022 17:34:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3588F8D002A; Wed, 1 Jun 2022 13:34:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 303528D0028; Wed, 1 Jun 2022 13:34:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 218378D002A; Wed, 1 Jun 2022 13:34:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0F1DE8D0028 for ; Wed, 1 Jun 2022 13:34:38 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D5EEB355FB for ; Wed, 1 Jun 2022 17:34:37 +0000 (UTC) X-FDA: 79530366594.22.87D39A6 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf28.hostedemail.com (Postfix) with ESMTP id 51F49C006B for ; Wed, 1 Jun 2022 17:33:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C2FC41F8F6; Wed, 1 Jun 2022 17:34:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1654104875; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yPxZyhx2htcqKKisRfas+7IPl/BgzIKaMSj2ZzajJIg=; b=Zb2LaSt9f1Tc76mutvDU037fDI5D321olqGbDaNXnmynn+N2s6atIKSkK5Y2IX9UxSE2Xj 1xKdHDQHvzWDIBFqgn0YeqVhdD0GzVvG+BaTKCOSscjDcYv+6zWjtFhum+K2+kA6Dx5v7N 8q+6TE1IKVeTz+g8OKmulMU9YQaPyVg= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 87E381330F; Wed, 1 Jun 2022 17:34:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lWQnICujl2LiaQAAMHmgww (envelope-from ); Wed, 01 Jun 2022 17:34:35 +0000 Date: Wed, 1 Jun 2022 19:34:34 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Muchun Song Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, longman@redhat.com Subject: Re: [PATCH v5 03/11] mm: memcontrol: prepare objcg API for non-kmem usage Message-ID: <20220601173434.GB16134@blackbody.suse.cz> References: <20220530074919.46352-1-songmuchun@bytedance.com> <20220530074919.46352-4-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220530074919.46352-4-songmuchun@bytedance.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: rsgj6nmutqk3p439wg6pu9nfn14cj4yp Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Zb2LaSt9; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf28.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 51F49C006B X-HE-Tag: 1654104838-798462 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello. On Mon, May 30, 2022 at 03:49:11PM +0800, Muchun Song wrote: > So we also allocate an object cgroup for the root_mem_cgroup. This change made me wary that this patch also kmem charging in the root_mem_cgroup. Fortunately, get_obj_cgroup_from_current won't return this objcg so all is fine. > +} > +#else > +static inline void obj_cgroup_release_bytes(struct obj_cgroup *objcg) > +{ > +} > +#endif This empty body is for !CONFIG_MEMCG_KMEM, however, the subsequent use for LRU pages makes no use of these, so it's warranted. Altogether, I find this correct, hence Reviewed-by: Michal Koutný