From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6DC5C433F5 for ; Tue, 31 May 2022 18:05:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44A036B0072; Tue, 31 May 2022 14:05:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FC926B0073; Tue, 31 May 2022 14:05:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3111E6B0074; Tue, 31 May 2022 14:05:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2307B6B0072 for ; Tue, 31 May 2022 14:05:22 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E5B92138D for ; Tue, 31 May 2022 18:05:21 +0000 (UTC) X-FDA: 79526815242.11.39EE2C5 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf13.hostedemail.com (Postfix) with ESMTP id CCF4420065 for ; Tue, 31 May 2022 18:04:48 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E399CB80FAB; Tue, 31 May 2022 18:05:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6816DC385A9; Tue, 31 May 2022 18:05:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1654020318; bh=q/QrzhxSevkZMdXBh3GLbF1bFU+ZLYHCVAWkr3URa/A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=n5wVDE7/Ehb1Ic4NuM1EWvqZoBVnybTrXH81d5QOba6d5k3QkkopLkhcnm8rmeYY2 xglHfBcxGoJRYpksAQqyJEQ9hHG2ppmlgaipLVHgJmdOE/Crm9WB0xXqo1HrBSXH2G A7j256zUbBTza8+NcmO0Aupy0YQyDYUL2wfA5O4o= Date: Tue, 31 May 2022 11:05:17 -0700 From: Andrew Morton To: Miaohe Lin Cc: , , Alex Sierra , Christoph Hellwig , Felix Kuehling , Alistair Poppple Subject: Re: [PATCH] mm/migrate: skip unsupported ZONE_DEVICE page in migrate_vma_collect_pmd() Message-Id: <20220531110517.51b839799201e9e75684375a@linux-foundation.org> In-Reply-To: <20220531122530.17996-1-linmiaohe@huawei.com> References: <20220531122530.17996-1-linmiaohe@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CCF4420065 X-Stat-Signature: dyswgtcpxqn5jpquczhj9n3et1t6b1pe X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="n5wVDE7/"; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1654020288-602606 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 31 May 2022 20:25:30 +0800 Miaohe Lin wrote: > For now we only support migrating to un-addressable device memory. Other > types of ZONE_DEVICE pages are not supported yet. So skip those pages in > MIGRATE_VMA_SELECT_SYSTEM case to save useless effort. > https://lkml.kernel.org/r/20220531155629.20057-4-alex.sierra@amd.com just made similar-but-different changes here. Please review those. Normally I'm merge your fixlet ahead of the larger changes and redo Alex's patchset. Because Alex's larger patchset might never get mainlined, so your fixlet would then get lost. But in this case, your fixlet doesn't seem important enough to be churning things around in that way? > --- a/mm/migrate_device.c > +++ b/mm/migrate_device.c > @@ -157,6 +157,11 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp, > goto next; > } > page = vm_normal_page(migrate->vma, addr, pte); > + /* > + * Other types of ZONE_DEVICE page are not supported. > + */ > + if (page && is_zone_device_page(page)) > + goto next; > mpfn = migrate_pfn(pfn) | MIGRATE_PFN_MIGRATE; > mpfn |= pte_write(pte) ? MIGRATE_PFN_WRITE : 0; > }