From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3B79C433FE for ; Tue, 31 May 2022 17:52:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 491C86B0072; Tue, 31 May 2022 13:52:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43D246B0073; Tue, 31 May 2022 13:52:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32E396B0074; Tue, 31 May 2022 13:52:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 23B2F6B0072 for ; Tue, 31 May 2022 13:52:05 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C3A5734328 for ; Tue, 31 May 2022 17:52:04 +0000 (UTC) X-FDA: 79526781768.15.47AB19F Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf10.hostedemail.com (Postfix) with ESMTP id 38861C0064 for ; Tue, 31 May 2022 17:51:21 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AC880B81117; Tue, 31 May 2022 17:52:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20E06C385A9; Tue, 31 May 2022 17:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1654019521; bh=OEffCozNQpohIH5eyJLNtoMpjRKcnRWUeID9VGyaAnw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OxCWkOU/KlRTYWJIU77tH7DqxetqA3KFACMH/TOXjqVqEk57kgpF3O26zUfycCHWE 0XYuBliVm13YxzKcZun2fxq2A7DNTiLDxFBiJVJtOrM35PmN6mal9g9Pk4AOxBxEeq QHLAVyMduwHx2dCypmsfubYv34RV1vZiaR6MK9HM= Date: Tue, 31 May 2022 10:52:00 -0700 From: Andrew Morton To: andrey.konovalov@linux.dev Cc: Marco Elver , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH 2/3] mm: introduce clear_highpage_tagged Message-Id: <20220531105200.587db61db99f19e308a05c5e@linux-foundation.org> In-Reply-To: References: <4c76a95aff79723de76df146a10888a5a9196faf.1654011120.git.andreyknvl@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: t3my6az7cb4e44nc84aop1tcf4cixepe Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="OxCWkOU/"; dmarc=none; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 38861C0064 X-HE-Tag: 1654019481-140846 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 31 May 2022 17:43:49 +0200 andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > Add a clear_highpage_tagged() helper that does clear_highpage() on a > page potentially tagged by KASAN. clear_highpage_kasan_tagged() would be a better name, no? --- a/include/linux/highmem.h~mm-introduce-clear_highpage_tagged-fix +++ a/include/linux/highmem.h @@ -243,7 +243,7 @@ static inline void clear_highpage(struct kunmap_local(kaddr); } -static inline void clear_highpage_tagged(struct page *page) +static inline void clear_highpage_kasan_tagged(struct page *page) { u8 tag; --- a/mm/page_alloc.c~mm-introduce-clear_highpage_tagged-fix +++ a/mm/page_alloc.c @@ -1311,7 +1311,7 @@ static void kernel_init_pages(struct pag /* s390's use of memset() could override KASAN redzones. */ kasan_disable_current(); for (i = 0; i < numpages; i++) - clear_highpage_tagged(page + i); + clear_highpage_kasan_tagged(page + i); kasan_enable_current(); } _