From: Andrew Morton <akpm@linux-foundation.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] mm/swapfile: avoid confusing swap cache statistics
Date: Mon, 30 May 2022 16:04:09 -0700 [thread overview]
Message-ID: <20220530160409.c9b17085adb6112d8580f37d@linux-foundation.org> (raw)
In-Reply-To: <20220527092626.31883-3-linmiaohe@huawei.com>
On Fri, 27 May 2022 17:26:25 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:
> At swapoff time, we're going to swap in the pages continuously. So calling
> lookup_swap_cache would confuse statistics. We should use find_get_page
> directly here.
Why is the existing behaviour wrong? swapoff() has to swap stuff in to
be able to release the swap device. Why do you believe that this
swapin activity should not be accounted?
next prev parent reply other threads:[~2022-05-30 23:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 9:26 [PATCH 0/3] A few fixup patches for swap Miaohe Lin
2022-05-27 9:26 ` [PATCH 1/3] mm/swapfile: make security_vm_enough_memory_mm() work as expected Miaohe Lin
2022-05-30 23:02 ` Andrew Morton
2022-05-31 2:40 ` Miaohe Lin
2022-05-27 9:26 ` [PATCH 2/3] mm/swapfile: avoid confusing swap cache statistics Miaohe Lin
2022-05-30 23:04 ` Andrew Morton [this message]
2022-05-31 2:55 ` Miaohe Lin
2022-05-31 12:58 ` David Hildenbrand
2022-06-01 2:11 ` Miaohe Lin
2022-06-01 7:53 ` David Hildenbrand
2022-06-02 7:29 ` Miaohe Lin
2022-06-02 8:41 ` David Hildenbrand
2022-06-06 3:14 ` Miaohe Lin
2022-05-27 9:26 ` [PATCH 3/3] mm/swapfile: fix possible data races of inuse_pages Miaohe Lin
2022-05-31 13:02 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220530160409.c9b17085adb6112d8580f37d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox