From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E701C433EF for ; Sun, 29 May 2022 23:47:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3C908D0002; Sun, 29 May 2022 19:47:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EA598D0001; Sun, 29 May 2022 19:47:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9312A8D0002; Sun, 29 May 2022 19:47:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 830768D0001 for ; Sun, 29 May 2022 19:47:21 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 46A0612091D for ; Sun, 29 May 2022 23:47:21 +0000 (UTC) X-FDA: 79520419482.23.48DDC4F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 5FCCB4002D for ; Sun, 29 May 2022 23:46:41 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9EB0F60F9D; Sun, 29 May 2022 23:47:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDDBFC385A9; Sun, 29 May 2022 23:47:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1653868039; bh=ZxuH3VqJUJH1J3jzVH7bIwy/T6x2dAX8M/Zj5GnElfg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=e62CRT1/Y+gtGZ1y4URtOIZ0WumVsdH/AUKvCzgVQGbnBArb7wk9n2dKBBUUGB1Qx a0rMQkZMXjy5Qw8HwejKBuhmH9mMWNJDVyHKfNoT7qt3N+bgevKg37xRCMuv2Zmp/E hwV5Nr+aKY4j8QpCBocItMEat3kD80OyiG+GEJj0= Date: Sun, 29 May 2022 16:47:18 -0700 From: Andrew Morton To: Jakub =?UTF-8?B?TWF0xJtuYQ==?= Cc: linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, vbabka@suse.cz, mhocko@kernel.org, mgorman@techsingularity.net, willy@infradead.org, liam.howlett@oracle.com, hughd@google.com, kirill@shutemov.name, riel@surriel.com, rostedt@goodmis.org, peterz@infradead.org Subject: Re: [PATCH v2 2/2] [PATCH 2/2] mm: add merging after mremap resize Message-Id: <20220529164718.ed1eac7d614804c825fae9fd@linux-foundation.org> In-Reply-To: <20220527211708.839033-3-matenajakub@gmail.com> References: <20220527211708.839033-1-matenajakub@gmail.com> <20220527211708.839033-3-matenajakub@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5FCCB4002D X-Stat-Signature: iaq53h71iomwj7ghixas5ny7o1pr41tk Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="e62CRT1/"; dmarc=none; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-HE-Tag: 1653868001-983629 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 27 May 2022 23:17:08 +0200 Jakub Matěna wrote: > When mremap call results in expansion, it might be possible to merge the > VMA with the next VMA which might become adjacent. This patch adds > vma_merge call after the expansion is done to try and merge. Thanks. Would it make sense to add a test case for this in (I assume) tools/testing/selftests/vm/mremap_test.c? Maybe parse /proc/self/maps and check that the merging occurred as expected?