From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9F45C433EF for ; Sat, 28 May 2022 02:15:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 038E28D0003; Fri, 27 May 2022 22:15:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F29898D0001; Fri, 27 May 2022 22:15:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E38E58D0003; Fri, 27 May 2022 22:15:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D490E8D0001 for ; Fri, 27 May 2022 22:15:39 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A5A4935985 for ; Sat, 28 May 2022 02:15:39 +0000 (UTC) X-FDA: 79513535598.17.489E68D Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf20.hostedemail.com (Postfix) with ESMTP id 67A131C003B for ; Sat, 28 May 2022 02:15:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653704138; x=1685240138; h=date:from:to:cc:subject:message-id:mime-version; bh=I//4GmesjASoO/fskqF86IbRnBJs5ux7J+T8NANiQUI=; b=ggf40rSpp68jUQsaG2OdMHiR9xzcVG/WiYsjZTfW2JZzbfv25hPgzNTS XlyxEbIGbAXZOcPsY+65PHf//BkjCHqim5LN0mqeR8d+tqz8BiTSVBFxf CRSqx2lK/2CC0j4CiA5v9oy71mggCUhxL2Px/ej1NSo4lWancXldHl/z/ A9cs/zVJGyNwliB9aM4f867IJUjm9T37rxwODVNRZRKQ0GF8asACoOYRw p4q572pt8tcOQWFaUr23oL/KZ2YRfxFaDIXijD7a+qcPq2EDECq8dWhp7 y0sGiz68SMvBTz5Oyf2fWJWwpURvXuLOPzTOpUfk0VMQ1nsJuo5Ofp7ot Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10360"; a="273428085" X-IronPort-AV: E=Sophos;i="5.91,257,1647327600"; d="scan'208";a="273428085" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2022 19:15:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,257,1647327600"; d="scan'208";a="747332344" Received: from lkp-server01.sh.intel.com (HELO db63a1be7222) ([10.239.97.150]) by orsmga005.jf.intel.com with ESMTP; 27 May 2022 19:15:33 -0700 Received: from kbuild by db63a1be7222 with local (Exim 4.95) (envelope-from ) id 1nulzI-0005Mz-Oh; Sat, 28 May 2022 02:15:32 +0000 Date: Sat, 28 May 2022 10:15:15 +0800 From: kernel test robot To: Kees Cook Cc: kbuild-all@lists.01.org, Linux Memory Management List , Dan Li Subject: [linux-next:master 3417/14198] drivers/misc/lkdtm/cfi.c:100:27: sparse: sparse: Using plain integer as NULL pointer Message-ID: <202205281038.F1GyW2IY-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 67A131C003B X-Stat-Signature: 48w1inzaj8qsnefqt5orh65i7dwjzd5e X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ggf40rSp; spf=none (imf20.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1653704122-625847 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: d3fde8ff50ab265749704bd7fbcf70d35235421f commit: 2e53b877dc1258d4ac3de98f496bb88ec3bf5e25 [3417/14198] lkdtm: Add CFI_BACKWARD to test ROP mitigations config: arc-randconfig-s031-20220527 (https://download.01.org/0day-ci/archive/20220528/202205281038.F1GyW2IY-lkp@intel.com/config) compiler: arceb-elf-gcc (GCC) 11.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-14-g5a0004b5-dirty # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2e53b877dc1258d4ac3de98f496bb88ec3bf5e25 git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git fetch --no-tags linux-next master git checkout 2e53b877dc1258d4ac3de98f496bb88ec3bf5e25 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arc SHELL=/bin/bash drivers/misc/lkdtm/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) >> drivers/misc/lkdtm/cfi.c:100:27: sparse: sparse: Using plain integer as NULL pointer drivers/misc/lkdtm/cfi.c:72:13: sparse: sparse: non size-preserving pointer to integer cast drivers/misc/lkdtm/cfi.c:72:13: sparse: sparse: non size-preserving integer to pointer cast drivers/misc/lkdtm/cfi.c:87:13: sparse: sparse: non size-preserving pointer to integer cast drivers/misc/lkdtm/cfi.c:87:13: sparse: sparse: non size-preserving integer to pointer cast vim +100 drivers/misc/lkdtm/cfi.c 96 97 static void lkdtm_CFI_BACKWARD(void) 98 { 99 /* Use calculated gotos to keep labels addressable. */ > 100 void *labels[] = {0, &&normal, &&redirected, &&check_normal, &&check_redirected}; 101 102 pr_info("Attempting unchecked stack return address redirection ...\n"); 103 104 /* Always false */ 105 if (force_check) { 106 /* 107 * Prepare to call with NULLs to avoid parameters being treated as 108 * constants in -02. 109 */ 110 set_return_addr_unchecked(NULL, NULL); 111 set_return_addr(NULL, NULL); 112 if (force_check) 113 goto *labels[1]; 114 if (force_check) 115 goto *labels[2]; 116 if (force_check) 117 goto *labels[3]; 118 if (force_check) 119 goto *labels[4]; 120 return; 121 } 122 123 /* 124 * Use fallthrough switch case to keep basic block ordering between 125 * set_return_addr*() and the label after it. 126 */ 127 switch (force_check) { 128 case 0: 129 set_return_addr_unchecked(&&normal, &&redirected); 130 fallthrough; 131 case 1: 132 normal: 133 /* Always true */ 134 if (!force_check) { 135 pr_err("FAIL: stack return address manipulation failed!\n"); 136 /* If we can't redirect "normally", we can't test mitigations. */ 137 return; 138 } 139 break; 140 default: 141 redirected: 142 pr_info("ok: redirected stack return address.\n"); 143 break; 144 } 145 146 pr_info("Attempting checked stack return address redirection ...\n"); 147 148 switch (force_check) { 149 case 0: 150 set_return_addr(&&check_normal, &&check_redirected); 151 fallthrough; 152 case 1: 153 check_normal: 154 /* Always true */ 155 if (!force_check) { 156 pr_info("ok: control flow unchanged.\n"); 157 return; 158 } 159 160 check_redirected: 161 pr_err("FAIL: stack return address was redirected!\n"); 162 break; 163 } 164 165 if (IS_ENABLED(CONFIG_ARM64_PTR_AUTH_KERNEL)) { 166 pr_expected_config(CONFIG_ARM64_PTR_AUTH_KERNEL); 167 return; 168 } 169 if (IS_ENABLED(CONFIG_SHADOW_CALL_STACK)) { 170 pr_expected_config(CONFIG_SHADOW_CALL_STACK); 171 return; 172 } 173 pr_warn("This is probably expected, since this %s was built *without* %s=y nor %s=y\n", 174 lkdtm_kernel_info, 175 "CONFIG_ARM64_PTR_AUTH_KERNEL", "CONFIG_SHADOW_CALL_STACK"); 176 } 177 -- 0-DAY CI Kernel Test Service https://01.org/lkp