From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C27BC433EF for ; Fri, 27 May 2022 23:37:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 733818D0003; Fri, 27 May 2022 19:37:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E44D8D0001; Fri, 27 May 2022 19:37:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 583BF8D0003; Fri, 27 May 2022 19:37:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4AAED8D0001 for ; Fri, 27 May 2022 19:37:22 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0C57C35C46 for ; Fri, 27 May 2022 23:37:22 +0000 (UTC) X-FDA: 79513136724.31.C27A9C1 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf19.hostedemail.com (Postfix) with ESMTP id CC68E1A0035 for ; Fri, 27 May 2022 23:37:07 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id j10so8871073lfe.12 for ; Fri, 27 May 2022 16:37:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=J+HEM1XZa0sy/b3V0gcwypiEOba1ZZAFxr2ass/Bc/k=; b=KaiJVkdhS9GxcUZdH7TXoY1kzZIbIL0KGrXTtPH5vePuGcMbiuQz0wFdE/sZxznQXm Ij+X6IJxXLKGUi3PNdt1yuRitQzFbNpUTjqY6DyQybVIUFPibzEQgjH/hGp7iRdUsP24 67agV3aZTV/fDEuduTEIOxX/V/rfUSmCcfK4oJ1wexCdLLv8boBR/OHgrC7gh0Z9JLDI xfoDUHMarvR4VhTQPSPoDMueMxhLIs8TKd7o5GyU90nSAN2/qYNTvhXs3xBaF4U0mqd/ sljAlT3BpxRD+1a0WwOA7BIaEAtjPNllKi4bRd7AD6BUWfcZEze72uxYz2kImwzNXsJY E98A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=J+HEM1XZa0sy/b3V0gcwypiEOba1ZZAFxr2ass/Bc/k=; b=KvD3WW5gkMUxKv+MF2NNMGbCi7cefrulX7Nwx0A8SSrAhl8KPNuKKyRsM+2gI7me4w rIyQ6N47swYjq85RxJv1lfwVdsQZs2cZ/5PJ0EfYiWKj/VCd8CFC3Zs0XHQAQ+UkiID3 NqgMzgV0XYHxxkjnBav7M+I8dDUiamjctxczSitsXAniKUhZru9daq/7UuquZanXNnra +lwfSqEnfTbT/7CMVWKvzcnOYjMtmMvxA5WM+d2GfZQyp941XRsXkNpm2rhm2iFXqJ0t Bjonx/P9xlL3F0kqd0GuoVbw1UpfRgNwqEqJnSFQN2bdVBY1EZ5JqR2JwE+fE209vHH/ M4pw== X-Gm-Message-State: AOAM5316cMgXMvcjDStWn5DslddA422AZJ+tVPaA5MLOwYQ1nMoNxENG +5aMkiWbIpLR/YX2A/x1bJ7Wsg== X-Google-Smtp-Source: ABdhPJya26gfWjXOurelttGI3jMJSVrxfCHFs3URpcAcCY2mOlGUtdts0WB3wFjgiifG5/VPAwXMmA== X-Received: by 2002:ac2:5e73:0:b0:478:9aca:4a00 with SMTP id a19-20020ac25e73000000b004789aca4a00mr12438267lfr.394.1653694640018; Fri, 27 May 2022 16:37:20 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id o22-20020ac24c56000000b00477b11144e9sm1061804lfk.66.2022.05.27.16.37.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 May 2022 16:37:18 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 86A191094B9; Sat, 28 May 2022 02:39:15 +0300 (+03) Date: Sat, 28 May 2022 02:39:15 +0300 From: "Kirill A. Shutemov" To: Jakub =?utf-8?Q?Mat=C4=9Bna?= Cc: akpm@linux-foundation.org, linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, vbabka@suse.cz, mhocko@kernel.org, mgorman@techsingularity.net, willy@infradead.org, liam.howlett@oracle.com, hughd@google.com, riel@surriel.com, rostedt@goodmis.org, peterz@infradead.org Subject: Re: [PATCH 1/2] [PATCH 1/2] mm: refactor of vma_merge() Message-ID: <20220527233915.55oe6jittuogavot@box.shutemov.name> References: <20220527104810.24736-1-matenajakub@gmail.com> <20220527104810.24736-2-matenajakub@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220527104810.24736-2-matenajakub@gmail.com> Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=shutemov-name.20210112.gappssmtp.com header.s=20210112 header.b=KaiJVkdh; dmarc=none; spf=none (imf19.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.47) smtp.mailfrom=kirill@shutemov.name X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: CC68E1A0035 X-Stat-Signature: cgtyy5pfqwsqo9cd3o34sou9n4bctbt5 X-HE-Tag: 1653694627-549111 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 27, 2022 at 12:48:09PM +0200, Jakub Matěna wrote: > Refactor vma_merge() to make it shorter and more understandable. > Main change is the elimination of code duplicity in the case of > merge next check. This is done by first doing checks and caching > the results before executing the merge itself. The variable 'area' is > divided into 'mid' and 'res' as previously it was used for two purposes, > as the middle VMA between prev and next and also as the result of the > merge itself. Exit paths are also unified. > > Signed-off-by: Jakub Matěna You've ignored my ack. Or is there substantial changes that you want me to review again? -- Kirill A. Shutemov