From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EA89C4332F for ; Fri, 27 May 2022 15:51:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33F228D0038; Fri, 27 May 2022 11:51:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CCAF8D002F; Fri, 27 May 2022 11:51:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EE858D0038; Fri, 27 May 2022 11:51:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DCB038D002F for ; Fri, 27 May 2022 11:51:12 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id AACB81209B6 for ; Fri, 27 May 2022 15:51:12 +0000 (UTC) X-FDA: 79511961984.31.8C8ED61 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 0782120082 for ; Fri, 27 May 2022 15:50:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=J6ZYsEntBqEXv9QBv404Bgc48t6nDUnBZmpt61SYzKU=; b=LiGJJ8kQ87fQsAY1OFDvu/IXG9 /p1ELYx7K+911E5NCn4ItDp8JJrDnoTO9ECbIH2Duh1Z9YUkJ6yZIEuA5dbNjxgX6Qdzx/rda66rW AGs08STh0x9LpH3Mg1EndQxzbmsG/AJPeoZ9mWumUXE7L4nBjEDbfcNH2cdVWQjPJTi5x5J08SRM5 DAaRYZx5IlbfV7I4j/wQn08l/SodtBqgIC6orOO9/l2C1BXJDz1YfEFq5GwdIgWit2Yb6uJivEBx6 h5nH07gRWAl5RfUExkLlfBEGGLErgDOhLc2rm5rOW2ytAvUgEFQrIH1/n+YHXSnfuHdhn9piTbMny qmzN0+RA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nucEa-002CWU-Kx; Fri, 27 May 2022 15:50:40 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 05/24] hfs: Remove check for PageError Date: Fri, 27 May 2022 16:50:17 +0100 Message-Id: <20220527155036.524743-6-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220527155036.524743-1-willy@infradead.org> References: <20220527155036.524743-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 0782120082 X-Stat-Signature: ngo8tufommfyf1mxzmme6i3kbo4wgrhx Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LiGJJ8kQ; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1653666642-905337 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If read_mapping_page() encounters an error, it returns an errno, not a page with PageError set, so this is dead code. Signed-off-by: Matthew Wilcox (Oracle) --- fs/hfs/bnode.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/hfs/bnode.c b/fs/hfs/bnode.c index c0a73a6ffb28..c83fd0e8404d 100644 --- a/fs/hfs/bnode.c +++ b/fs/hfs/bnode.c @@ -296,10 +296,6 @@ static struct hfs_bnode *__hfs_bnode_create(struct hfs_btree *tree, u32 cnid) page = read_mapping_page(mapping, block++, NULL); if (IS_ERR(page)) goto fail; - if (PageError(page)) { - put_page(page); - goto fail; - } node->page[i] = page; } -- 2.34.1