From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA30C433F5 for ; Fri, 27 May 2022 15:51:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40CBD8D0034; Fri, 27 May 2022 11:51:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EAA18D002F; Fri, 27 May 2022 11:51:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2ACA28D0034; Fri, 27 May 2022 11:51:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0F4B68D002F for ; Fri, 27 May 2022 11:51:04 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E3B3F6099D for ; Fri, 27 May 2022 15:51:03 +0000 (UTC) X-FDA: 79511961606.11.1E04C7E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 1CF2F140080 for ; Fri, 27 May 2022 15:50:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=Zo8tq/TxfJl7q8EhTtWvLm5Ur9WjdGrs5spowtCnbu0=; b=qcPSaSoXqtBX3E6xq92irx5JaP bPnZQYfyuQpJH5dUaAHLxgHrBf7bEaAGoJV9OgCZ5RvsINeJ4mEPBcpwg3oZ6J/V6BVm5ucCdu4H3 yEKBxmpWLfbtRDKBSXiqQ7SMRTiceSitmxvnIcNxm38GL4drrpyzmUa6VXVk6/kWnvr0QP41+GK+5 RTfPO+owL4U7hwQ8lz6x0pTpcB80iAwpxSanR5Kt++mnQKMEyZmMLhCPx5Q4jLkaxMzzy0r+VlSCm c1WRE4pXThYYcb14d+EsOIYwAGVz1USFd8CXkYheq/ok3DwifdRlz4wCxsqFx1eTvQeZ4FC22MO+E DWv8pAKQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nucEa-002CWS-IY; Fri, 27 May 2022 15:50:40 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 04/24] gfs: Check PageUptodate instead of PageError Date: Fri, 27 May 2022 16:50:16 +0100 Message-Id: <20220527155036.524743-5-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220527155036.524743-1-willy@infradead.org> References: <20220527155036.524743-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 1CF2F140080 X-Stat-Signature: dyxh5fkci35uzrpp1upgowugkoipbh91 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qcPSaSoX; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam09 X-HE-Tag: 1653666649-826168 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is the correct flag to test to know if the read completed successfully. Signed-off-by: Matthew Wilcox (Oracle) --- fs/gfs2/lops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c index 6ba51cbb94cf..9a9a35d68bd5 100644 --- a/fs/gfs2/lops.c +++ b/fs/gfs2/lops.c @@ -474,7 +474,7 @@ static void gfs2_jhead_process_page(struct gfs2_jdesc *jd, unsigned long index, page = find_get_page(jd->jd_inode->i_mapping, index); wait_on_page_locked(page); - if (PageError(page)) + if (!PageUptodate(page)) *done = true; if (!*done) -- 2.34.1