From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DD31C433EF for ; Fri, 27 May 2022 15:51:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71BDC8D002E; Fri, 27 May 2022 11:50:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 605D98D002C; Fri, 27 May 2022 11:50:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A5AE8D002E; Fri, 27 May 2022 11:50:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 36CC48D002C for ; Fri, 27 May 2022 11:50:48 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id AD3D98094E for ; Fri, 27 May 2022 15:50:47 +0000 (UTC) X-FDA: 79511960934.19.9675769 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 2138A140030 for ; Fri, 27 May 2022 15:50:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=e0XmxPlauxAq5iJGHvK9f2GU7KuIll9jS6x2f9sMeng=; b=MDKaxVqoC1OyUk+eWBfs18A3xL /9ii/C2wDZ1MNkbvtp3MfXFVQZpxbNKOk/fXOHeD+5Wbz1MlcyROvN1eeiOXPVBsiV/0uYGWo7OvR zyn1d5CiojeJ2aoAVNY518jko8t5QPOhU5C1qucKwX4JnS8eTAnuJmxtGgJ8/X4GH1ZKhipDSufhy EfFsr4DSLISbxACgLYVXcuftx2npvYtJQrUdOu+zOxXFPUGqJe8w6pj2yo09bImNqp+8BcotBAhs4 0Q7E9OZ6rtFeVveDja5DgkKJSzPN65wNbiNTIF6JfbKgUGvqFjNub1bm8mHtYJJSt2VXsRgDIdVap wLq/lkqQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nucEc-002CXv-AF; Fri, 27 May 2022 15:50:42 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 23/24] hostfs: Handle page write errors correctly Date: Fri, 27 May 2022 16:50:35 +0100 Message-Id: <20220527155036.524743-24-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220527155036.524743-1-willy@infradead.org> References: <20220527155036.524743-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2138A140030 X-Stat-Signature: gxr6qzhr9h1rz7khkqgoka7mcqgtk9hw Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=MDKaxVqo; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1653666642-642808 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If a page can't be written back, we need to call mapping_set_error(), not clear the page's Uptodate flag. Also remove the clearing of PageError on success; that flag is used for read errors, not write errors. Signed-off-by: Matthew Wilcox (Oracle) --- fs/hostfs/hostfs_kern.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c index cc1bc6f93a01..07881b76d42f 100644 --- a/fs/hostfs/hostfs_kern.c +++ b/fs/hostfs/hostfs_kern.c @@ -416,15 +416,15 @@ static int hostfs_writepage(struct page *page, struct writeback_control *wbc) err = write_file(HOSTFS_I(inode)->fd, &base, buffer, count); if (err != count) { - ClearPageUptodate(page); + if (err >= 0) + err = -EIO; + mapping_set_error(mapping, err); goto out; } if (base > inode->i_size) inode->i_size = base; - if (PageError(page)) - ClearPageError(page); err = 0; out: -- 2.34.1