From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 014D4C433FE for ; Fri, 27 May 2022 15:50:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 440568D0029; Fri, 27 May 2022 11:50:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3DB28D002C; Fri, 27 May 2022 11:50:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 321538D0028; Fri, 27 May 2022 11:50:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 010238D0027 for ; Fri, 27 May 2022 11:50:44 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id CE91560A2E for ; Fri, 27 May 2022 15:50:44 +0000 (UTC) X-FDA: 79511960808.17.2985DD3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 7BC46C0031 for ; Fri, 27 May 2022 15:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=8Xen5gC1HhkspCEo+ZyScnM78AzlIPquQEw05FXhHuQ=; b=pr2MHsNtJ4o0Up/SM7gZj552Qv MBlnsEH1oadbJ1tbDIue/HxbW1HHv8JdfkD4Uc8hmg4N53qWtF5nr6X3EAuYAWUCJqRm7XBsnje1o peatyEetm9/zjQ01/TSaHvAlWkRNfh5RC7eo1AN/U6Lp17Kjv5UkRur80bK1klQlB+URXYGi/L+R+ MEhYRygopP0fZLDL/UjRf3ROTu2Tropvugs4i3wgMOm9t/AZZhHDoE2cAqLRPdQSvczr5q36lNJ2F PDK2sx7jK5Xbi2IOi/NKhFQ9hd2YK1uWIZgiw4/gIV4OaIMVuN7Gw0CjTlbgIn8C1VuvwgetDAeLC MgQk7TUw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nucEc-002CXj-4F; Fri, 27 May 2022 15:50:42 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 21/24] buffer: Don't test folio error in block_read_full_folio() Date: Fri, 27 May 2022 16:50:33 +0100 Message-Id: <20220527155036.524743-22-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220527155036.524743-1-willy@infradead.org> References: <20220527155036.524743-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 7BC46C0031 X-Stat-Signature: dkkniqdcrhbqjexc98mpe8xhyf4xpitz Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pr2MHsNt; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1653666604-187779 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We can cache this information in a local variable instead of communicating from one part of the function to another via folio flags. Signed-off-by: Matthew Wilcox (Oracle) --- fs/buffer.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index c37a9c3bfb2f..5a4609b8b2b4 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -2259,6 +2259,7 @@ int block_read_full_folio(struct folio *folio, get_block_t *get_block) unsigned int blocksize, bbits; int nr, i; int fully_mapped = 1; + bool page_error = false; VM_BUG_ON_FOLIO(folio_test_large(folio), folio); @@ -2283,8 +2284,10 @@ int block_read_full_folio(struct folio *folio, get_block_t *get_block) if (iblock < lblock) { WARN_ON(bh->b_size != blocksize); err = get_block(inode, iblock, bh, 0); - if (err) + if (err) { folio_set_error(folio); + page_error = true; + } } if (!buffer_mapped(bh)) { folio_zero_range(folio, i * blocksize, @@ -2311,7 +2314,7 @@ int block_read_full_folio(struct folio *folio, get_block_t *get_block) * All buffers are uptodate - we can set the folio uptodate * as well. But not if get_block() returned an error. */ - if (!folio_test_error(folio)) + if (!page_error) folio_mark_uptodate(folio); folio_unlock(folio); return 0; -- 2.34.1