From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0885C433EF for ; Fri, 27 May 2022 15:50:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29E518D0023; Fri, 27 May 2022 11:50:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 216718D0022; Fri, 27 May 2022 11:50:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DF3C8D0021; Fri, 27 May 2022 11:50:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 009168D001E for ; Fri, 27 May 2022 11:50:43 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id B16991209B6 for ; Fri, 27 May 2022 15:50:43 +0000 (UTC) X-FDA: 79511960766.25.A8B4C03 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 6449C80040 for ; Fri, 27 May 2022 15:50:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=tCiC/LNfeYVDL+hpPkwMSf65SMCxXRoZcgr2jCxRYnI=; b=T5uqWMX/dp9SRQ8FhdUZqQnkhX 6xnjbD0GqE9Qx4q8o6rCGdxsr9Im0SFwCMgqR39gkk8jgDFF7t/hEBrzaNI4i2cT8GONwXkEwS9MD yqDrVd4htYqstbiquy+//WpUQgObnWFDDOLAWtCqA1Rcw0WISWYhO/5Fdm14eMr9B+Hdv5hCSJDOY BBEXkWlvb4lepoh+Kqc500dozdqxWcnlkGdfdjQng4ndCP07gzIVvE9FBoxVjsBY4uApMw4e0ToUS 2uLbNig6eQ/7JP1gMwsqO4PDaI/YwF5hFBH1rppCuqB9v15ej1aDmm4Js4lIHvWoWrdOr4FnSIoxq VSKqJ0Fw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nucEb-002CXR-QV; Fri, 27 May 2022 15:50:41 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 18/24] buffer: Remove check for PageError Date: Fri, 27 May 2022 16:50:30 +0100 Message-Id: <20220527155036.524743-19-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220527155036.524743-1-willy@infradead.org> References: <20220527155036.524743-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: aewcr91jcke6cryif81uwos8kpftk96n X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="T5uqWMX/"; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6449C80040 X-HE-Tag: 1653666612-464468 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If a buffer is completed with an error, its uptodate flag will be clear, so the page_uptodate variable will have been set to 0. There's no need to check PageError here. Signed-off-by: Matthew Wilcox (Oracle) --- fs/buffer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index 898c7f301b1b..c37a9c3bfb2f 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -282,10 +282,10 @@ static void end_buffer_async_read(struct buffer_head *bh, int uptodate) spin_unlock_irqrestore(&first->b_uptodate_lock, flags); /* - * If none of the buffers had errors and they are all - * uptodate then we can set the page uptodate. + * If all of the buffers are uptodate then we can set the page + * uptodate. */ - if (page_uptodate && !PageError(page)) + if (page_uptodate) SetPageUptodate(page); unlock_page(page); return; -- 2.34.1