From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DEA2C433FE for ; Fri, 27 May 2022 15:51:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 627538D0030; Fri, 27 May 2022 11:50:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D97D8D002C; Fri, 27 May 2022 11:50:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D8A48D0030; Fri, 27 May 2022 11:50:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1621F8D002F for ; Fri, 27 May 2022 11:50:54 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id DCCC760A2C for ; Fri, 27 May 2022 15:50:53 +0000 (UTC) X-FDA: 79511961186.17.F913033 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id D8C06100058 for ; Fri, 27 May 2022 15:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=c2PSGU+T+5Ia0BRl8u+GB44oYmq/DVLwd9sUaj+DKts=; b=Dtw+Y2W54adVVz09SgjOgFLZbE mHr9LwsCSZX8Rv4Hgp3W4bRTC7UEMlY/zEwB4EmXZpUeCjrnmofa3ZsXC+oRQhpkRQnqxz6W/YvhC fNHFp43Y/erGNEmOIbs35QRm+bHocoGboYyxWwq6FAnIq9PNmBing0Xw1m7mWx5OLWuWnZ56FuwFF 4tkdXa01YWebNMyzsQfpV4Rnkmn0Cn42tpopfJLOs3lxyCXm1qROnXbBE6wxqX/yQF7sjnQF0jeW2 aLj/yCwdh/PDEFjTOEpmdgdlN6XZMfwbfnu+RoTwxr/2F2WImuCUpt7xdTMZOl99gcalmjtVKFJtj 5MAC+wGw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nucEb-002CWg-2I; Fri, 27 May 2022 15:50:41 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 11/24] ntfs3: Remove check for PageError Date: Fri, 27 May 2022 16:50:23 +0100 Message-Id: <20220527155036.524743-12-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220527155036.524743-1-willy@infradead.org> References: <20220527155036.524743-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: iukywj5kzdowotsxxbzsuyme864ac79f Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Dtw+Y2W5; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D8C06100058 X-HE-Tag: 1653666622-754700 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If read_mapping_page() encounters an error, it returns an errno, not a page with PageError set, so this is dead code. Signed-off-by: Matthew Wilcox (Oracle) --- fs/ntfs3/ntfs_fs.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/ntfs3/ntfs_fs.h b/fs/ntfs3/ntfs_fs.h index 8de129a6419b..f28726c4e845 100644 --- a/fs/ntfs3/ntfs_fs.h +++ b/fs/ntfs3/ntfs_fs.h @@ -896,13 +896,8 @@ static inline struct page *ntfs_map_page(struct address_space *mapping, { struct page *page = read_mapping_page(mapping, index, NULL); - if (!IS_ERR(page)) { + if (!IS_ERR(page)) kmap(page); - if (!PageError(page)) - return page; - ntfs_unmap_page(page); - return ERR_PTR(-EIO); - } return page; } -- 2.34.1