From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAE8AC433EF for ; Wed, 25 May 2022 11:23:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 768238D0003; Wed, 25 May 2022 07:23:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 716E38D0002; Wed, 25 May 2022 07:23:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 627B18D0003; Wed, 25 May 2022 07:23:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4E7638D0002 for ; Wed, 25 May 2022 07:23:41 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1D39034393 for ; Wed, 25 May 2022 11:23:41 +0000 (UTC) X-FDA: 79504030242.30.D33EC69 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf24.hostedemail.com (Postfix) with ESMTP id 56EFC18002B for ; Wed, 25 May 2022 11:23:27 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1C66A23A; Wed, 25 May 2022 04:23:39 -0700 (PDT) Received: from wubuntu (unknown [10.57.65.214]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5571B3F70D; Wed, 25 May 2022 04:23:37 -0700 (PDT) Date: Wed, 25 May 2022 12:23:34 +0100 From: Qais Yousef To: Mel Gorman Cc: Andrew Morton , Nicolas Saenz Julienne , Marcelo Tosatti , Vlastimil Babka , Michal Hocko , LKML , Linux-MM Subject: Re: [PATCH 3/6] mm/page_alloc: Split out buddy removal code from rmqueue into separate helper Message-ID: <20220525112334.k5ovoydr4iv3wuna@wubuntu> References: <20220512085043.5234-1-mgorman@techsingularity.net> <20220512085043.5234-4-mgorman@techsingularity.net> <20220523160921.k34jjbpd62bmc7fj@wubuntu> <20220524115543.GX3441@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220524115543.GX3441@techsingularity.net> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 56EFC18002B X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf24.hostedemail.com: domain of qais.yousef@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=qais.yousef@arm.com X-Stat-Signature: ffkc77gxj6ynyg6ooxc856wieo5y5e5b X-HE-Tag: 1653477807-194923 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05/24/22 12:55, Mel Gorman wrote: > On Mon, May 23, 2022 at 05:09:21PM +0100, Qais Yousef wrote: > > On 05/12/22 09:50, Mel Gorman wrote: > > > This is a preparation page to allow the buddy removal code to be reused > > > in a later patch. > > > > > > No functional change. > > > > > > Signed-off-by: Mel Gorman > > > Tested-by: Minchan Kim > > > Acked-by: Minchan Kim > > > --- > > > > I see this splat when this patch is applied on 5.10.107 kernel: > > > > > > > I could resolve it by applying this patch: > > > > diff --git a/mm/vmstat.c b/mm/vmstat.c > > index 80c1e0a0f094e..92fb0c08296ef 100644 > > --- a/mm/vmstat.c > > +++ b/mm/vmstat.c > > @@ -957,11 +957,11 @@ void __inc_numa_state(struct zone *zone, > > u16 __percpu *p = pcp->vm_numa_stat_diff + item; > > u16 v; > > > > - v = __this_cpu_inc_return(*p); > > + v = this_cpu_inc_return(*p); > > > > if (unlikely(v > NUMA_STATS_THRESHOLD)) { > > zone_numa_state_add(v, zone, item); > > - __this_cpu_write(*p, 0); > > + this_cpu_write(*p, 0); > > } > > } > > > > 5.18 does not have __inc_numa_state() so it's likely you are missing > backports, probably f19298b9516c1a031b34b4147773457e3efe743b at minimum. Thanks Mel. Sorry it seems I stopped my analysis tad too soon. It seems the dependency chain is more than that commit. I couldn't backport it on its own. I just happened to be an accidental user of that kernel (it's an Android 5.10 tree). I did report it there too, but I thought (wrongly) this could benefit this upstream discussion. I'll take it there. Thanks! -- Qais Yousef