From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10345C433FE for ; Wed, 25 May 2022 06:01:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C3EB8D0003; Wed, 25 May 2022 02:01:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 573288D0002; Wed, 25 May 2022 02:01:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 484A28D0003; Wed, 25 May 2022 02:01:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3AF068D0002 for ; Wed, 25 May 2022 02:01:53 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1412960DA3 for ; Wed, 25 May 2022 06:01:53 +0000 (UTC) X-FDA: 79503219306.14.5F43772 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf26.hostedemail.com (Postfix) with ESMTP id 714FE140020 for ; Wed, 25 May 2022 06:01:48 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 70C24227EE6; Wed, 25 May 2022 08:01:43 +0200 (CEST) Date: Wed, 25 May 2022 08:01:42 +0200 From: "hch@lst.de" To: Luis Chamberlain Cc: "Edgecombe, Rick P" , Christophe Leroy , "hch@lst.de" , "dave@stgolabs.net" , "linux-kernel@vger.kernel.org" , "daniel@iogearbox.net" , "peterz@infradead.org" , "ast@kernel.org" , "bpf@vger.kernel.org" , "kernel-team@fb.com" , "linux-mm@kvack.org" , "song@kernel.org" , "Torvalds, Linus" , "arnd@arndb.de" , Adam Manzanares Subject: Re: [PATCH v3 bpf-next 5/8] bpf: use module_alloc_huge for bpf_prog_pack Message-ID: <20220525060142.GB10762@lst.de> References: <20220520031548.338934-1-song@kernel.org> <20220520031548.338934-6-song@kernel.org> <17c6110273d59e3fdeea3338abefac03951ff404.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 714FE140020 X-Stat-Signature: 3ndd8cgkgd5ecyp73e3q7unykh3ytfxa X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=none; spf=none (imf26.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-HE-Tag: 1653458508-218532 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 24, 2022 at 03:08:12PM -0700, Luis Chamberlain wrote: > > A rename seems good to me. Module space is really just dynamically > > allocated text space now. There used to be a vmalloc_exec() that > > allocated text in vmalloc space, > > Yes I saw that but it was generic and it did not do the arch-specific > override, and so that is why Christoph ripped it out and open coded > it on the only user, on module_alloc(). It it also because random code does not have any business allocating executable memory. Executable memory in kernel is basically for modules and module-like code like eBPF, and no one else has any business allocating pages with the execute bit set (or the NX bit not set).