From: Qais Yousef <qais.yousef@arm.com>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nicolas Saenz Julienne <nsaenzju@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>,
Michal Hocko <mhocko@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH 3/6] mm/page_alloc: Split out buddy removal code from rmqueue into separate helper
Date: Mon, 23 May 2022 17:09:21 +0100 [thread overview]
Message-ID: <20220523160921.k34jjbpd62bmc7fj@wubuntu> (raw)
In-Reply-To: <20220512085043.5234-4-mgorman@techsingularity.net>
On 05/12/22 09:50, Mel Gorman wrote:
> This is a preparation page to allow the buddy removal code to be reused
> in a later patch.
>
> No functional change.
>
> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
> Tested-by: Minchan Kim <minchan@kernel.org>
> Acked-by: Minchan Kim <minchan@kernel.org>
> ---
I see this splat when this patch is applied on 5.10.107 kernel:
[ 132.779332] CPU: 1 PID: 203 Comm: klogd Not tainted 5.10.107-00039-g83962808e276 #28
[ 132.782470] BUG: using __this_cpu_add_return() in preemptible [00000000] code: udhcpc/229
[ 132.787809] Hardware name: ARM Juno development board (r2) (DT)
[ 132.787841] Call trace:
[ 132.787881] dump_backtrace+0x0/0x2c0
[ 132.787921] show_stack+0x18/0x28
[ 132.787963] dump_stack_lvl+0x108/0x150
[ 132.788003] dump_stack+0x1c/0x58
[ 132.788049] check_preemption_disabled+0xf4/0x108
[ 132.788095] __this_cpu_preempt_check+0x20/0x2c
[ 132.788135] __inc_numa_state+0x3c/0x120
[ 132.788177] get_page_from_freelist+0xd6c/0x1ac8
[ 132.788220] __alloc_pages_nodemask+0x224/0x1780
[ 132.797359] caller is __this_cpu_preempt_check+0x20/0x2c
[ 132.803579] alloc_pages_current+0xb0/0x150
[ 132.803621] allocate_slab+0x2d0/0x408
[ 132.803662] ___slab_alloc+0x43c/0x640
[ 132.803704] __slab_alloc.isra.0+0x70/0xc8
[ 132.803747] __kmalloc_node_track_caller+0x10c/0x2d8
[ 132.803792] __kmalloc_reserve.isra.0+0x80/0x160
[ 132.803835] __alloc_skb+0xd0/0x2a8
[ 132.883893] alloc_skb_with_frags+0x64/0x2a0
[ 132.888632] sock_alloc_send_pskb+0x420/0x438
[ 132.893465] unix_dgram_sendmsg+0x1d4/0x930
[ 132.898112] __sys_sendto+0x16c/0x230
[ 132.902198] __arm64_sys_sendto+0x78/0x98
[ 132.906654] el0_svc_common.constprop.0+0xac/0x278
I could resolve it by applying this patch:
diff --git a/mm/vmstat.c b/mm/vmstat.c
index 80c1e0a0f094e..92fb0c08296ef 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -957,11 +957,11 @@ void __inc_numa_state(struct zone *zone,
u16 __percpu *p = pcp->vm_numa_stat_diff + item;
u16 v;
- v = __this_cpu_inc_return(*p);
+ v = this_cpu_inc_return(*p);
if (unlikely(v > NUMA_STATS_THRESHOLD)) {
zone_numa_state_add(v, zone, item);
- __this_cpu_write(*p, 0);
+ this_cpu_write(*p, 0);
}
}
AFAICT zone_statistics() no longer protected by the spin_lock_irqsave(), so
preemption no longer disabled.
You need to have CONFIG_NUMA and CONFIG_DEBUG_PREEMPT enabled to reproduce
this.
HTH
Thanks!
--
Qais Yousef
next prev parent reply other threads:[~2022-05-23 16:09 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 8:50 [PATCH 0/6] Drain remote per-cpu directly v3 Mel Gorman
2022-05-12 8:50 ` [PATCH 1/6] mm/page_alloc: Add page->buddy_list and page->pcp_list Mel Gorman
2022-05-13 11:59 ` Nicolas Saenz Julienne
2022-05-19 9:36 ` Vlastimil Babka
2022-05-12 8:50 ` [PATCH 2/6] mm/page_alloc: Use only one PCP list for THP-sized allocations Mel Gorman
2022-05-19 9:45 ` Vlastimil Babka
2022-05-12 8:50 ` [PATCH 3/6] mm/page_alloc: Split out buddy removal code from rmqueue into separate helper Mel Gorman
2022-05-13 12:01 ` Nicolas Saenz Julienne
2022-05-19 9:52 ` Vlastimil Babka
2022-05-23 16:09 ` Qais Yousef [this message]
2022-05-24 11:55 ` Mel Gorman
2022-05-25 11:23 ` Qais Yousef
2022-05-12 8:50 ` [PATCH 4/6] mm/page_alloc: Remove unnecessary page == NULL check in rmqueue Mel Gorman
2022-05-13 12:03 ` Nicolas Saenz Julienne
2022-05-19 10:57 ` Vlastimil Babka
2022-05-19 12:13 ` Mel Gorman
2022-05-19 12:26 ` Vlastimil Babka
2022-05-12 8:50 ` [PATCH 5/6] mm/page_alloc: Protect PCP lists with a spinlock Mel Gorman
2022-05-13 12:22 ` Nicolas Saenz Julienne
2022-05-12 8:50 ` [PATCH 6/6] mm/page_alloc: Remotely drain per-cpu lists Mel Gorman
2022-05-12 19:37 ` Andrew Morton
2022-05-13 15:04 ` Mel Gorman
2022-05-13 15:19 ` Nicolas Saenz Julienne
2022-05-13 18:23 ` Mel Gorman
2022-05-17 12:57 ` Mel Gorman
2022-05-12 19:43 ` [PATCH 0/6] Drain remote per-cpu directly v3 Andrew Morton
2022-05-13 14:23 ` Mel Gorman
2022-05-13 19:38 ` Andrew Morton
2022-05-16 10:53 ` Mel Gorman
2022-05-13 12:24 ` Nicolas Saenz Julienne
2022-05-17 23:35 ` Qian Cai
2022-05-18 12:51 ` Mel Gorman
2022-05-18 16:27 ` Qian Cai
2022-05-18 17:15 ` Paul E. McKenney
2022-05-19 13:29 ` Qian Cai
2022-05-19 19:15 ` Paul E. McKenney
2022-05-19 21:05 ` Qian Cai
2022-05-19 21:29 ` Paul E. McKenney
2022-05-18 17:26 ` Marcelo Tosatti
2022-05-18 17:44 ` Marcelo Tosatti
2022-05-18 18:01 ` Nicolas Saenz Julienne
2022-05-26 17:19 ` Qian Cai
2022-05-27 8:39 ` Mel Gorman
2022-05-27 12:58 ` Qian Cai
-- strict thread matches above, loose matches on Subject: below --
2022-05-09 13:07 [RFC PATCH 0/6] Drain remote per-cpu directly v2 Mel Gorman
2022-05-09 13:08 ` [PATCH 3/6] mm/page_alloc: Split out buddy removal code from rmqueue into separate helper Mel Gorman
2022-04-20 9:59 [RFC PATCH 0/6] Drain remote per-cpu directly Mel Gorman
2022-04-20 9:59 ` [PATCH 3/6] mm/page_alloc: Split out buddy removal code from rmqueue into separate helper Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523160921.k34jjbpd62bmc7fj@wubuntu \
--to=qais.yousef@arm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=mtosatti@redhat.com \
--cc=nsaenzju@redhat.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox