From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76108C433EF for ; Fri, 20 May 2022 23:30:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5E806B0072; Fri, 20 May 2022 19:30:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0CD66B0073; Fri, 20 May 2022 19:30:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD6276B0074; Fri, 20 May 2022 19:30:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BB4146B0072 for ; Fri, 20 May 2022 19:30:00 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8DC7960748 for ; Fri, 20 May 2022 23:30:00 +0000 (UTC) X-FDA: 79487716560.16.7C23CB7 Received: from mail3-166.sinamail.sina.com.cn (mail3-166.sinamail.sina.com.cn [202.108.3.166]) by imf11.hostedemail.com (Postfix) with SMTP id 60ABE40026 for ; Fri, 20 May 2022 23:29:52 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([114.249.57.134]) by sina.com (172.16.97.23) with ESMTP id 6288242D0001F319; Fri, 21 May 2022 07:28:47 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 40316054919336 From: Hillf Danton To: Peter Zijlstra Cc: frederic@kernel.org, paulmck@kernel.org, rjw@rjwysocki.net, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, jpoimboe@kernel.org Subject: Re: [RFC][PATCH 4/9] idle: Fix rcu_idle_*() usage Date: Sat, 21 May 2022 07:29:45 +0800 Message-Id: <20220520232945.2585-1-hdanton@sina.com> In-Reply-To: <20220519213421.808983977@infradead.org> References: <20220519212750.656413111@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 60ABE40026 X-Stat-Signature: aa8916bcq7o7zknwn6mj7mb59yqmgx1y Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.166 as permitted sender) smtp.mailfrom=hdanton@sina.com X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1653089392-646029 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 19 May 2022 23:27:54 +0200 Peter Zijlstra wrote: > @@ -150,12 +151,12 @@ static void enter_s2idle_proper(struct c > */ > stop_critical_timings(); > if (!(target_state->flags & CPUIDLE_FLAG_RCU_IDLE)) > - rcu_idle_enter(); > + cpuidle_rcu_enter(); > target_state->enter_s2idle(dev, drv, index); > if (WARN_ON_ONCE(!irqs_disabled())) > - local_irq_disable(); > + raw_local_irq_disable(); > if (!(target_state->flags & CPUIDLE_FLAG_RCU_IDLE)) > - rcu_idle_exit(); > + cpuidle_rcu_enter(); Why does it need to enter once more instead of exit, if it is not typo? Hillf > tick_unfreeze(); > start_critical_timings(); > > @@ -233,14 +234,14 @@ int cpuidle_enter_state(struct cpuidle_d > > stop_critical_timings(); > if (!(target_state->flags & CPUIDLE_FLAG_RCU_IDLE)) > - rcu_idle_enter(); > + cpuidle_rcu_enter(); > > entered_state = target_state->enter(dev, drv, index); > if (WARN_ON_ONCE(!irqs_disabled())) > raw_local_irq_disable(); > > if (!(target_state->flags & CPUIDLE_FLAG_RCU_IDLE)) > - rcu_idle_exit(); > + cpuidle_rcu_exit(); This looks like the correct sequence in sanity. > start_critical_timings(); > > sched_clock_idle_wakeup_event();