From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41DE5C433EF for ; Fri, 20 May 2022 17:00:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C45BC6B0071; Fri, 20 May 2022 13:00:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF5586B0072; Fri, 20 May 2022 13:00:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABD2B6B0073; Fri, 20 May 2022 13:00:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9C0EB6B0071 for ; Fri, 20 May 2022 13:00:09 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 6CBA38194A for ; Fri, 20 May 2022 17:00:09 +0000 (UTC) X-FDA: 79486734138.10.F036AF0 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf09.hostedemail.com (Postfix) with ESMTP id DA50E140060 for ; Fri, 20 May 2022 16:59:57 +0000 (UTC) Received: by mail-qt1-f181.google.com with SMTP id y15so3054237qtx.4 for ; Fri, 20 May 2022 10:00:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=fFacJbvwa5BeiY3szVOg+2bHWvSVuVrSCav3PMs3Wy4=; b=FTtqHS4Ab3DM4iXG5smV6wqAV7NigY5YOsrNfdM9EDqDL5th5wGo+wZVRy8FzYswDT SDGetT+iY1qj8QP7mFHxOIrcrxoTg1NqhzsPapXSFVu5aIeW1EAtipIjCmrRcUz29+Bf hWHp4zj09YNJkFNnFMW8OiKSexYuzZGbIkol9548EZJ9Rf41Y30NSDUob2I7XkCeZl4O pfSVSMFREIQS6MrbI490t5eTt2FG/rgno1k87u3e7A+WECLqsnH9niksYJaD+/E5R528 P/0JMNG2HVIKLA4xI7BcX1v1jJ5kDukehFUYmZ7xykFZntaS5Z58ilBHB5ZecS0fTxju EZ3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=fFacJbvwa5BeiY3szVOg+2bHWvSVuVrSCav3PMs3Wy4=; b=A9J3t6QD9F0wBDIF85Y6zHlnUe9M4ufL4YrG7UoUwCQtyDHofh3kSvjpvtgmErXmsu Mn3lqlVFnkLXkLJtyJzrgN8CwKsar9hk7HpZc5yTe+tbygorJSSLFkdHiH04mc6dodb/ IR5DSWgToh6hkmzHyWmGuqpDbPPZ0d5D5K5guBCgNfwo5TN115qwO9XJIE4UCSjKcsCm Y8SWX/Rw/VYWOYWedIVfR2b8PMntDwLdiqHH8Bjs7qnNuo7lcX4nqaePYcPHyugUAMGv 82Hc57M9N8I+68ArntHpVfs/MG2t+mQJHCVvOrLZ/GRzdTR6Aq1JyTzqKs8pwiGCpOg6 vPbA== X-Gm-Message-State: AOAM533SzxZlqtyctZ8xHc/uxHbqA/bkGhh4dBrYkT5jX/yah04plkGm S8D4E2WbaNCknhC9RudQeQ== X-Google-Smtp-Source: ABdhPJwJLVP/OySs/WRd/Wh6kqhmG3bqXMDgdLqLgevH4DAll8yOHHXdgwbOB6cDskW54cnK9Iwx3Q== X-Received: by 2002:ac8:7f01:0:b0:2f9:1c7d:c68 with SMTP id f1-20020ac87f01000000b002f91c7d0c68mr3619868qtk.504.1653066008225; Fri, 20 May 2022 10:00:08 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id k12-20020ac8478c000000b002f3d7c13a24sm13041qtq.4.2022.05.20.10.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 10:00:07 -0700 (PDT) Date: Fri, 20 May 2022 13:00:05 -0400 From: Kent Overstreet To: Christophe JAILLET Cc: Roman Gushchin , Andrew Morton , linux-mm@kvack.org, Dave Chinner , linux-kernel@vger.kernel.org, Hillf Danton Subject: Re: [PATCH v3 2/6] mm: shrinkers: introduce debugfs interface for memory shrinkers Message-ID: <20220520170005.a3dlxk6a2qbrjdoq@moria.home.lan> References: <20220509183820.573666-1-roman.gushchin@linux.dev> <20220509183820.573666-3-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: DA50E140060 X-Stat-Signature: qzszgxh5e75nfd38kcqrxxe3takikszh X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FTtqHS4A; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com X-HE-Tag: 1653065997-177444 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 20, 2022 at 06:58:12PM +0200, Christophe JAILLET wrote: > Le 09/05/2022 à 20:38, Roman Gushchin a écrit : > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > index 3fd7a2e9eaf1..5fa65a649798 100644 > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -733,6 +733,15 @@ config SLUB_STATS > > out which slabs are relevant to a particular load. > > Try running: slabinfo -DA > > +config SHRINKER_DEBUG > > + default y > > The previous version of the serie had default 'n'. > Is it intentional to have it now activated by default? It looked more like a > tuning functionality when fine grained mangement of shrinker is needed. I think having this on by default if you've already enabled debugfs is smart - it doesn't add runtime overhead, just a bit of code, and things that make the system more observable are great to have on by default.