From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 117A7C433F5 for ; Fri, 20 May 2022 16:45:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 970D86B0071; Fri, 20 May 2022 12:45:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F93A6B0072; Fri, 20 May 2022 12:45:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 772E86B0073; Fri, 20 May 2022 12:45:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 655056B0071 for ; Fri, 20 May 2022 12:45:20 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 31EEF34B23 for ; Fri, 20 May 2022 16:45:20 +0000 (UTC) X-FDA: 79486696800.02.35760CC Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by imf15.hostedemail.com (Postfix) with ESMTP id 583F2A00D7 for ; Fri, 20 May 2022 16:44:58 +0000 (UTC) Received: by mail-qk1-f178.google.com with SMTP id x65so3035298qke.2 for ; Fri, 20 May 2022 09:45:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=a8xIXPdHqKY/S928N5n4lpCrih7fBjePFCe31Nm3HEU=; b=cmvcEGmOVBjFBzLUYaEoVPYa92JOWcLZT3qRym44KayCXwLx04F/hGWoRYq1fVPgWb kk+veu9Clf2Pyaf1Sualbrjs0o5wb0jBTUi8V6HVNLuIlyQqwBVgTnw0axO1k2FFk7uQ X/80AU7Lx2CF4AgaVK+O1TFCih8iAo8Xoaiwd61pFQfUQH7UjYenW87j8ScDLjAn1RH/ c9V1ZImHn8kP/4KarRbzdR2vJr1x+nkui06a8fminuD3r4SnkDmRI/otkV1FzyPeQ+V4 ZOarhhNpCNPoDXaxUnq2AR68aQIplxZETm1Hz7bT7aU4Y/PiMjarNWA5keH7cmMldiD2 SeQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a8xIXPdHqKY/S928N5n4lpCrih7fBjePFCe31Nm3HEU=; b=VaV/M/Ay7ZhfMaSh6eH1NNlko3qiccJzv9epBDf3PBRd1ihyPXzzKqYwqcQgqKAlwf 2I98BdTtXXNPKkSSR40YsVXiko0HJCynyKeW3WN9KyF/ixxb3a+qpiGSwIzkb6yPl+Vq 4JcpaLdoPW+XtkfQ7pcor6VozjMKXttV5MCjqAjwoIqIS3JDzjiskRAzazYPW5VKtfqK nUUlvYs3tPB8C4uNGZdyXp8/bnrAKigQZghvqwu3URzBkirk3MG3GQ+3DgmSiuWvV/oX UtkRRw4a7NvdB2waOwfixeWCaZ1/FwOSBCc4FzoyvdxlWFhhuZf+5fwEjEuZwaSICpRw aE0Q== X-Gm-Message-State: AOAM532JP4vBFjBG0CJWkpnUUMLvHgwy1oO1GjzwVj+B8uVjHe82ol2u 0kQRI6DNHtEHWWssnEoWDw== X-Google-Smtp-Source: ABdhPJyKLOM4Ryqhmi5CW9j0Bz6v9+5ljLoMoiDX4xitkxq7asAc2Y5lcbyIGJGXCejQlR6E/nj4FQ== X-Received: by 2002:a37:5805:0:b0:69f:c640:f5e8 with SMTP id m5-20020a375805000000b0069fc640f5e8mr6794806qkb.586.1653065114732; Fri, 20 May 2022 09:45:14 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id h198-20020a379ecf000000b006a33f89bb00sm2470514qke.81.2022.05.20.09.45.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 09:45:14 -0700 (PDT) Date: Fri, 20 May 2022 12:45:12 -0400 From: Kent Overstreet To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, Dave Chinner , linux-kernel@vger.kernel.org, Hillf Danton , Christophe JAILLET Subject: Re: [PATCH v3 2/6] mm: shrinkers: introduce debugfs interface for memory shrinkers Message-ID: <20220520164512.dqqbb5gkmfm6f4g6@moria.home.lan> References: <20220509183820.573666-1-roman.gushchin@linux.dev> <20220509183820.573666-3-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220509183820.573666-3-roman.gushchin@linux.dev> X-Rspamd-Queue-Id: 583F2A00D7 X-Stat-Signature: 6st47bqchodtiba3p11bocsrxamtw9qb Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cmvcEGmO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.222.178 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1653065098-484181 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 09, 2022 at 11:38:16AM -0700, Roman Gushchin wrote: > This commit introduces the /sys/kernel/debug/shrinker debugfs > interface which provides an ability to observe the state of > individual kernel memory shrinkers. > > Because the feature adds some memory overhead (which shouldn't be > large unless there is a huge amount of registered shrinkers), it's > guarded by a config option (enabled by default). > > This commit introduces the "count" interface for each shrinker > registered in the system. > > The output is in the following format: > ... > ... > ... > > To reduce the size of output on machines with many thousands cgroups, > if the total number of objects on all nodes is 0, the line is omitted. > > If the shrinker is not memcg-aware or CONFIG_MEMCG is off, 0 is > printed as cgroup inode id. If the shrinker is not numa-aware, 0's are > printed for all nodes except the first one. > > This commit gives debugfs entries simple numeric names, which are not > very convenient. The following commit in the series will provide > shrinkers with more meaningful names. > > Signed-off-by: Roman Gushchin I think this looks reasonable Reviewed-by: Kent Overstreet