From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9362FC433F5 for ; Fri, 20 May 2022 16:41:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF8C86B0071; Fri, 20 May 2022 12:41:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA7A26B0072; Fri, 20 May 2022 12:41:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6EA06B0073; Fri, 20 May 2022 12:41:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A8A5C6B0071 for ; Fri, 20 May 2022 12:41:19 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 7DA30617AA for ; Fri, 20 May 2022 16:41:19 +0000 (UTC) X-FDA: 79486686678.24.93D7C71 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by imf24.hostedemail.com (Postfix) with ESMTP id C9B3718001C for ; Fri, 20 May 2022 16:41:07 +0000 (UTC) Received: by mail-qk1-f172.google.com with SMTP id i68so6044328qke.11 for ; Fri, 20 May 2022 09:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TkubbAhF29FhvKmmevQzXLxG5QZHESokBvz4K1V6cEo=; b=DQTmBnn0ZDX0GRgKWYzWkYo55TP/cdT3Sakix+Rs2cFKA2gFDqImO7h9wrnhOZV02G HjwIZDaCTk2oQZlglY7Eu/yq4krTe7vortY0GAcNE1AJ0cnnDbZH5RgZaZrrNNYkbrrB OsdPP061S/hu1m4i8ty43+sZub9IaT8rYLedBoJ+LvBtXR+I1wWIUz27DliaHSnagx59 bHfNnizJLpublgU/8uUd8Pfc3v/FDLLkQ/NUDjv8Mgh8lpi+dayq2RQR+DUuXNw9lRc0 EkJFI9hKdXptcdBvacJQMrGVg/i+nIshFIzqSiUBe/oiIrt2LguoZ6fQTl//9Cf+UloH exHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TkubbAhF29FhvKmmevQzXLxG5QZHESokBvz4K1V6cEo=; b=eiWhBNj5jcnImpXYZHTsBUN4t7XApw/ZgUTU+afJdj/tyK+bKNgN2L+PuKb/fS2V1v 1dsG3yWlKZKWL41vIf+xxx+1IvuLs4ILPohUyV4TojlWHjPfAtPfZwDx74qOlwEdcgzx 7rPoX+rqEi+QdY46hTMUV4Q2uc5J9DzGOEZpT6/KsHHA+VcyhejS0FHdAzo8sIL+uJxC KDoazJrzb6ziTfKegnPG0RYYYcL6luiPpHWdP0TT4jj3XIjLbFWAHPjX6c+rf/+DHLTu 3Oet26XnZOS18qoSwE97cj3TBNL1oWqjg74EEfyLryaeZyPYOMWPnirMGCdQH/QC+1Ta f/+g== X-Gm-Message-State: AOAM531KcVd5uJnBZqcFutk38gBlBSnbd4Hx2MwCw9xo8ROHRl4e3+2U 1D5HXMk6qfSTCkbU/R8d1g== X-Google-Smtp-Source: ABdhPJwuB47wcY/9uJ/K+woiLyVarnXc36VZPpIKVTTXBtOZwt6WKU6VZYuiZ2eEIheGUN2zsVMoRg== X-Received: by 2002:a37:6189:0:b0:6a3:3622:794c with SMTP id v131-20020a376189000000b006a33622794cmr5147483qkb.210.1653064878240; Fri, 20 May 2022 09:41:18 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id w1-20020ac87e81000000b002f3b561957asm3745541qtj.13.2022.05.20.09.41.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 09:41:17 -0700 (PDT) Date: Fri, 20 May 2022 12:41:15 -0400 From: Kent Overstreet To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, Dave Chinner , linux-kernel@vger.kernel.org, Hillf Danton , Christophe JAILLET Subject: Re: [PATCH v3 3/6] mm: shrinkers: provide shrinkers with names Message-ID: <20220520164115.oectf3x5hkwesioi@moria.home.lan> References: <20220509183820.573666-1-roman.gushchin@linux.dev> <20220509183820.573666-4-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220509183820.573666-4-roman.gushchin@linux.dev> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C9B3718001C X-Stat-Signature: 4mt78mjswcyen5gp7hj3mgbpypfn1qde Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DQTmBnn0; spf=pass (imf24.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.222.172 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-HE-Tag: 1653064867-585926 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 09, 2022 at 11:38:17AM -0700, Roman Gushchin wrote: > diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c > index ad9f16689419..c1f734ab86b3 100644 > --- a/drivers/md/bcache/btree.c > +++ b/drivers/md/bcache/btree.c > @@ -812,7 +812,7 @@ int bch_btree_cache_alloc(struct cache_set *c) > c->shrink.seeks = 4; > c->shrink.batch = c->btree_pages * 2; > > - if (register_shrinker(&c->shrink)) > + if (register_shrinker(&c->shrink, "btree")) > pr_warn("bcache: %s: could not register shrinker\n", > __func__); These drivers need better names for their shrinkers - there will often be multiple instances in use on a system and we need to distinguish. Also, "btree" isn't a good name for the bcache shrinker - "bcache-%pU", c->set_uuid would be a good name for bcache's shrinker, it'll match up with the cache set directory in /sys/fs/bcache/. For others (device mapper, md, etc.) there should be a minor device number you can reference.