From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAAE9C433EF for ; Fri, 20 May 2022 13:26:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 374C06B0071; Fri, 20 May 2022 09:26:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 324926B0072; Fri, 20 May 2022 09:26:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C4866B0073; Fri, 20 May 2022 09:26:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 09FEE6B0071 for ; Fri, 20 May 2022 09:26:10 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9B4B6340BC for ; Fri, 20 May 2022 13:26:09 +0000 (UTC) X-FDA: 79486194858.11.629BF76 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf26.hostedemail.com (Postfix) with ESMTP id B289E1400CE for ; Fri, 20 May 2022 13:26:05 +0000 (UTC) Received: by mail-lf1-f51.google.com with SMTP id t25so14314180lfg.7 for ; Fri, 20 May 2022 06:26:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=/1UN+TaMaEHcux1d6IJ2KDdfHYHO4F5ExU+odphW0WU=; b=duNEHjCO0S0AOhMSt8aOd7DDMhxLHCQYK4g5GNHpXgS79y73DaQzAHn91LKMBCeOgD 1ZCPBLge3Cn96dQLOkEBsSLL8tRzqmO3sGp3nbRNnSbFVVEe05nol/Ts0rtg+UAT5qf9 KrNsl2YTbt0ua/0c/1wDITK3tAgfp6sVbaMT/a5Z5VnEQvz8Oiu5GqFx3STskU1zBxBj WAOOE/4pBlOlTxjiZHB9p7CsDOnB+gRVfv5zGcBZsLKkBGcQE8O7ImKGFxpuI6e/D3tb 3gHeJLsT5Hvg9DpkdOoOJfn7w5twy49l2wvF9yWDtJfERc9MdiKHDpnN+gWxhwOaosHA xfbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/1UN+TaMaEHcux1d6IJ2KDdfHYHO4F5ExU+odphW0WU=; b=MTIQX7EfsTTKf+DA9AkJYZ5vY+I/Vx8SL/ar2FWFkmfYHep5fZIlFTxZEbkF1UpqLv vXNuCqJ062Opsfr5v8vkvnAYVBo9TLKMelsEP3GveQKStLYDiCLyOHn+ZSw0fLuzlrFk tXypxVxOnAbwo3fChLTRNgLesQ86AILBo/b5Xy8aYjo0ujlc81NFlaRntdsGmhbUnsp8 2a1V4ZcmrgByTMAAh0Jr68vevrXcEwxY7HS9VxP4a1gpp4VnK4DFzqTpRlfYHbf6G9ua Xkq8+2sDUqJxg4N+n5QevzGYXuYWimkWrpnOTHm0CDVBumg3xq4+1g4ljbfxoBRvUii9 WsKA== X-Gm-Message-State: AOAM5339vo3c62SMFbiHNH7KsgxgaOW3WJxIulbqOQd0fKmp3wUMOZFq Rt/OrZPcn6+RG7e10yPnNHBjPQ== X-Google-Smtp-Source: ABdhPJwzB3/PlRlrkNXbK7mwUivWQKZ0qAFrQcRwuovyF2EoriPwqD771ALNFGv+zdxasA/ruuX6Zg== X-Received: by 2002:a05:6512:10cf:b0:473:b735:4fae with SMTP id k15-20020a05651210cf00b00473b7354faemr6947736lfg.93.1653053167466; Fri, 20 May 2022 06:26:07 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id o3-20020ac24e83000000b0047794db1ffasm659901lfr.237.2022.05.20.06.26.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 06:26:06 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 61396104AAB; Fri, 20 May 2022 16:28:00 +0300 (+03) Date: Fri, 20 May 2022 16:28:00 +0300 From: "Kirill A. Shutemov" To: Jakub =?utf-8?Q?Mat=C4=9Bna?= Cc: linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, vbabka@suse.cz, mhocko@kernel.org, mgorman@techsingularity.net, willy@infradead.org, liam.howlett@oracle.com, hughd@google.com, riel@surriel.com, rostedt@goodmis.org, peterz@infradead.org, david@redhat.com Subject: Re: [RFC PATCH v3 1/6] [PATCH 1/6] mm: refactor of vma_merge() Message-ID: <20220520132800.hijytnlyjqeesjfj@box.shutemov.name> References: <20220516125405.1675-1-matenajakub@gmail.com> <20220516125405.1675-2-matenajakub@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220516125405.1675-2-matenajakub@gmail.com> X-Rspam-User: X-Rspamd-Queue-Id: B289E1400CE X-Stat-Signature: s8ur4qdkkp1sihte38ryy1xuskm6ohaq Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=shutemov-name.20210112.gappssmtp.com header.s=20210112 header.b=duNEHjCO; spf=none (imf26.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.51) smtp.mailfrom=kirill@shutemov.name; dmarc=none X-Rspamd-Server: rspam03 X-HE-Tag: 1653053165-486429 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 16, 2022 at 02:54:00PM +0200, Jakub Matěna wrote: > Refactor vma_merge() to make it shorter, more understandable and > suitable for tracing of successful merges that are made possible by > following patches in the series. Main change is the elimination of code > duplicity in the case of merge next check. This is done by first doing > checks and caching the results before executing the merge itself. Exit > paths are also unified. > > Signed-off-by: Jakub Matěna Okay, this looks good: Acked-by: Kirill A. Shutemov I would also consider renaming 'area' to 'vma'. 'area' feels wrong to me, but maybe it is only me. -- Kirill A. Shutemov