From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BAC9C433EF for ; Fri, 20 May 2022 02:54:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AB0D6B0071; Thu, 19 May 2022 22:54:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 858626B0072; Thu, 19 May 2022 22:54:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7487E6B0073; Thu, 19 May 2022 22:54:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5FEA76B0071 for ; Thu, 19 May 2022 22:54:04 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 309B7AE9 for ; Fri, 20 May 2022 02:54:04 +0000 (UTC) X-FDA: 79484602008.18.C13CDDE Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf23.hostedemail.com (Postfix) with ESMTP id A9DCB1400DF for ; Fri, 20 May 2022 02:53:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653015240; x=1684551240; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=T+kF11TKdf/Yw7gXtARSc8OVLWJ0w+qZ62oJVBw1bK8=; b=U3/1lI+6OeE/s5+xZSbB/12Ff90rovOawmd9+rcg0T3gcWGpxK+WfoYY vqQo1FYr67BfPsiaB+U6FCgz1oUzxTPD/Qg80m0rl/WtOgHwG7GAlOVO0 P40MP8NSn/p+RCczuMHUG7BLX6SmjHr21a/XCISQqYYLq/FjXSVHtqGpx iJVGmdpYj5I2kj0IgxTZPE3rbCZlH1/16Vrh4rVjmX4d3+3A0GCJmbKX9 K7pxJE5FoxEhCnZODHBQAENNg3H7N4neUI6qBiH8ff0wCgZ5XuVafIvTP pDjZmpdpnPhLl9yb7UXZUuPgqD1rSZ8Nv0gFVeDXxFSTG5eLv861vp5F8 Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="272165040" X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="272165040" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 19:53:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="524426313" Received: from lkp-server02.sh.intel.com (HELO 242b25809ac7) ([10.239.97.151]) by orsmga003.jf.intel.com with ESMTP; 19 May 2022 19:53:52 -0700 Received: from kbuild by 242b25809ac7 with local (Exim 4.95) (envelope-from ) id 1nrsm0-0004DH-2n; Fri, 20 May 2022 02:53:52 +0000 Date: Fri, 20 May 2022 10:53:09 +0800 From: kernel test robot To: Song Liu , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, ast@kernel.org, daniel@iogearbox.net, mcgrof@kernel.org, torvalds@linux-foundation.org, rick.p.edgecombe@intel.com, kernel-team@fb.com, Song Liu Subject: Re: [PATCH v2 bpf-next 8/8] bpf: simplify select_bpf_prog_pack_size Message-ID: <202205201001.kKBulowq-lkp@intel.com> References: <20220519202037.2401584-9-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220519202037.2401584-9-song@kernel.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A9DCB1400DF X-Stat-Signature: a87ezajfm3dhj43dz4h8m5i4gd737gjd X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="U3/1lI+6"; spf=none (imf23.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1653015221-873730 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Song, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Song-Liu/bpf_prog_pack-followup/20220520-043417 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: x86_64-randconfig-a005 (https://download.01.org/0day-ci/archive/20220520/202205201001.kKBulowq-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project e00cbbec06c08dc616a0d52a20f678b8fbd4e304) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/2d5d4beb45be09f3130b694f49ab1b1fd1aa4470 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Song-Liu/bpf_prog_pack-followup/20220520-043417 git checkout 2d5d4beb45be09f3130b694f49ab1b1fd1aa4470 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash kernel/bpf/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> kernel/bpf/core.c:857:8: warning: unused variable 'ptr' [-Wunused-variable] void *ptr; ^ kernel/bpf/core.c:1656:12: warning: no previous prototype for function 'bpf_probe_read_kernel' [-Wmissing-prototypes] u64 __weak bpf_probe_read_kernel(void *dst, u32 size, const void *unsafe_ptr) ^ kernel/bpf/core.c:1656:1: note: declare 'static' if the function is not intended to be used outside of this translation unit u64 __weak bpf_probe_read_kernel(void *dst, u32 size, const void *unsafe_ptr) ^ static kernel/bpf/core.c:2099:6: warning: no previous prototype for function 'bpf_patch_call_args' [-Wmissing-prototypes] void bpf_patch_call_args(struct bpf_insn *insn, u32 stack_depth) ^ kernel/bpf/core.c:2099:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void bpf_patch_call_args(struct bpf_insn *insn, u32 stack_depth) ^ static 3 warnings generated. vim +/ptr +857 kernel/bpf/core.c e581094167beb6 Song Liu 2022-03-21 853 ef078600eec20f Song Liu 2022-03-11 854 static size_t select_bpf_prog_pack_size(void) ef078600eec20f Song Liu 2022-03-11 855 { ef078600eec20f Song Liu 2022-03-11 856 size_t size; ef078600eec20f Song Liu 2022-03-11 @857 void *ptr; ef078600eec20f Song Liu 2022-03-11 858 2d5d4beb45be09 Song Liu 2022-05-19 859 if (huge_vmalloc_supported()) { e581094167beb6 Song Liu 2022-03-21 860 size = BPF_HPAGE_SIZE * num_online_nodes(); 2d5d4beb45be09 Song Liu 2022-05-19 861 bpf_prog_pack_mask = BPF_HPAGE_MASK; 2d5d4beb45be09 Song Liu 2022-05-19 862 } else { ef078600eec20f Song Liu 2022-03-11 863 size = PAGE_SIZE; 96805674e5624b Song Liu 2022-03-21 864 bpf_prog_pack_mask = PAGE_MASK; 96805674e5624b Song Liu 2022-03-21 865 } ef078600eec20f Song Liu 2022-03-11 866 ef078600eec20f Song Liu 2022-03-11 867 return size; ef078600eec20f Song Liu 2022-03-11 868 } ef078600eec20f Song Liu 2022-03-11 869 -- 0-DAY CI Kernel Test Service https://01.org/lkp