From: kernel test robot <lkp@intel.com>
To: Song Liu <song@kernel.org>,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
linux-mm@kvack.org
Cc: kbuild-all@lists.01.org, ast@kernel.org, daniel@iogearbox.net,
mcgrof@kernel.org, torvalds@linux-foundation.org,
rick.p.edgecombe@intel.com, kernel-team@fb.com,
Song Liu <song@kernel.org>
Subject: Re: [PATCH v2 bpf-next 8/8] bpf: simplify select_bpf_prog_pack_size
Date: Fri, 20 May 2022 09:57:40 +0800 [thread overview]
Message-ID: <202205200913.DnvvOaAw-lkp@intel.com> (raw)
In-Reply-To: <20220519202037.2401584-9-song@kernel.org>
Hi Song,
I love your patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Song-Liu/bpf_prog_pack-followup/20220520-043417
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: i386-randconfig-a003 (https://download.01.org/0day-ci/archive/20220520/202205200913.DnvvOaAw-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/2d5d4beb45be09f3130b694f49ab1b1fd1aa4470
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Song-Liu/bpf_prog_pack-followup/20220520-043417
git checkout 2d5d4beb45be09f3130b694f49ab1b1fd1aa4470
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash kernel/bpf/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
kernel/bpf/core.c: In function 'select_bpf_prog_pack_size':
>> kernel/bpf/core.c:857:15: warning: unused variable 'ptr' [-Wunused-variable]
857 | void *ptr;
| ^~~
vim +/ptr +857 kernel/bpf/core.c
e581094167beb6 Song Liu 2022-03-21 853
ef078600eec20f Song Liu 2022-03-11 854 static size_t select_bpf_prog_pack_size(void)
ef078600eec20f Song Liu 2022-03-11 855 {
ef078600eec20f Song Liu 2022-03-11 856 size_t size;
ef078600eec20f Song Liu 2022-03-11 @857 void *ptr;
ef078600eec20f Song Liu 2022-03-11 858
2d5d4beb45be09 Song Liu 2022-05-19 859 if (huge_vmalloc_supported()) {
e581094167beb6 Song Liu 2022-03-21 860 size = BPF_HPAGE_SIZE * num_online_nodes();
2d5d4beb45be09 Song Liu 2022-05-19 861 bpf_prog_pack_mask = BPF_HPAGE_MASK;
2d5d4beb45be09 Song Liu 2022-05-19 862 } else {
ef078600eec20f Song Liu 2022-03-11 863 size = PAGE_SIZE;
96805674e5624b Song Liu 2022-03-21 864 bpf_prog_pack_mask = PAGE_MASK;
96805674e5624b Song Liu 2022-03-21 865 }
ef078600eec20f Song Liu 2022-03-11 866
ef078600eec20f Song Liu 2022-03-11 867 return size;
ef078600eec20f Song Liu 2022-03-11 868 }
ef078600eec20f Song Liu 2022-03-11 869
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-05-20 1:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 20:20 [PATCH v2 bpf-next 0/8] bpf_prog_pack followup Song Liu
2022-05-19 20:20 ` [PATCH v2 bpf-next 1/8] bpf: fill new bpf_prog_pack with illegal instructions Song Liu
2022-05-19 20:20 ` [PATCH v2 bpf-next 2/8] x86/alternative: introduce text_poke_set Song Liu
2022-05-19 20:20 ` [PATCH v2 bpf-next 3/8] bpf: introduce bpf_arch_text_invalidate for bpf_prog_pack Song Liu
2022-05-19 20:20 ` [PATCH v2 bpf-next 4/8] module: introduce module_alloc_huge Song Liu
2022-05-19 20:20 ` [PATCH v2 bpf-next 5/8] bpf: use module_alloc_huge for bpf_prog_pack Song Liu
2022-05-19 20:20 ` [PATCH v2 bpf-next 6/8] vmalloc: WARN for set_vm_flush_reset_perms() on huge pages Song Liu
2022-05-19 20:20 ` [PATCH v2 bpf-next 7/8] vmalloc: introduce huge_vmalloc_supported Song Liu
2022-05-20 0:52 ` kernel test robot
2022-05-19 20:20 ` [PATCH v2 bpf-next 8/8] bpf: simplify select_bpf_prog_pack_size Song Liu
2022-05-20 1:57 ` kernel test robot [this message]
2022-05-20 2:53 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205200913.DnvvOaAw-lkp@intel.com \
--to=lkp@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kbuild-all@lists.01.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=song@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox