From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A928C433EF for ; Thu, 19 May 2022 16:33:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A726A6B0073; Thu, 19 May 2022 12:33:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A228F6B0075; Thu, 19 May 2022 12:33:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EAE66B0078; Thu, 19 May 2022 12:33:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7F1D96B0073 for ; Thu, 19 May 2022 12:33:01 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5D73720FCF for ; Thu, 19 May 2022 16:33:01 +0000 (UTC) X-FDA: 79483036962.05.3875DAA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 8AB40120013 for ; Thu, 19 May 2022 16:32:51 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E3C1161CAB; Thu, 19 May 2022 16:32:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FE9BC385AA; Thu, 19 May 2022 16:32:57 +0000 (UTC) Date: Thu, 19 May 2022 12:32:55 -0400 From: Steven Rostedt To: Vasily Averin Cc: YoPOhRctb8wwbmY5@carbon.kvack.org, Shakeel Butt , Roman Gushchin , Vlastimil Babka , Matthew Wilcox , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Muchun Song , kernel@openvz.org, linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , linux-mm@kvack.org, Joonsoo Kim , David Rientjes , Pekka Enberg , Christoph Lameter , Michal Hocko Subject: Re: [PATCH v3] tracing: add 'accounted' entry into output of allocation tracepoints Message-ID: <20220519123255.543b8db6@gandalf.local.home> In-Reply-To: References: <20220518160447.20a7b96f@gandalf.local.home> <20220519100348.101d027d@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of "SRS0=wKKC=V3=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=wKKC=V3=goodmis.org=rostedt@kernel.org"; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8AB40120013 X-Stat-Signature: 6undqhwmmxqpdnuddp4zq9fhirk816i1 X-HE-Tag: 1652977971-136184 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 19 May 2022 19:29:36 +0300 Vasily Averin wrote: > Frankly speaking I vote for performance with both hands. > However I'm still would like to avoid new sparse warnings. > Christoph Hellwig just recently taught me, "never add '__force' before > thinking hard about them", but in this case I would need to use it three times. > > I found that bitwise typecasts can be avoided by using translation unions. > > What do you think about following trick? It's really up to you memory management folks. Although I may need to update libtraceevent to handle the union case. That may be a bit tricky. -- Steve