* Re: [PATCH v2] kexec_file: Drop weak attribute from arch_kexec_apply_relocations[_add] [not found] <20220519091237.676736-1-naveen.n.rao@linux.vnet.ibm.com> @ 2022-05-19 15:17 ` kernel test robot 2022-05-19 17:29 ` Andrew Morton 0 siblings, 1 reply; 2+ messages in thread From: kernel test robot @ 2022-05-19 15:17 UTC (permalink / raw) To: Naveen N. Rao, Andrew Morton, Michael Ellerman, Eric Biederman Cc: kbuild-all, Linux Memory Management List, linuxppc-dev, linux-kernel, kexec Hi "Naveen, I love your patch! Yet something to improve: [auto build test ERROR on f993aed406eaf968ba3867a76bb46c95336a33d0] url: https://github.com/intel-lab-lkp/linux/commits/Naveen-N-Rao/kexec_file-Drop-weak-attribute-from-arch_kexec_apply_relocations-_add/20220519-171432 base: f993aed406eaf968ba3867a76bb46c95336a33d0 config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20220519/202205192320.CoXevcfR-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/67171688c71cb5b05f26e0dfc45eec8d8d1428ff git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Naveen-N-Rao/kexec_file-Drop-weak-attribute-from-arch_kexec_apply_relocations-_add/20220519-171432 git checkout 67171688c71cb5b05f26e0dfc45eec8d8d1428ff # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash arch/s390/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): In file included from arch/s390/kernel/machine_kexec_reloc.c:3: >> arch/s390/include/asm/kexec.h:89:38: error: unknown type name 'Elf_Shdr'; did you mean 'elf_shdr'? 89 | Elf_Shdr *section, | ^~~~~~~~ | elf_shdr arch/s390/include/asm/kexec.h:90:44: error: unknown type name 'Elf_Shdr' 90 | const Elf_Shdr *relsec, | ^~~~~~~~ arch/s390/include/asm/kexec.h:91:44: error: unknown type name 'Elf_Shdr' 91 | const Elf_Shdr *symtab); | ^~~~~~~~ vim +89 arch/s390/include/asm/kexec.h 85 86 #ifdef CONFIG_KEXEC_FILE 87 struct purgatory_info; 88 int arch_kexec_apply_relocations_add(struct purgatory_info *pi, > 89 Elf_Shdr *section, -- 0-DAY CI Kernel Test Service https://01.org/lkp ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] kexec_file: Drop weak attribute from arch_kexec_apply_relocations[_add] 2022-05-19 15:17 ` [PATCH v2] kexec_file: Drop weak attribute from arch_kexec_apply_relocations[_add] kernel test robot @ 2022-05-19 17:29 ` Andrew Morton 0 siblings, 0 replies; 2+ messages in thread From: Andrew Morton @ 2022-05-19 17:29 UTC (permalink / raw) To: kernel test robot Cc: Naveen N. Rao, Michael Ellerman, Eric Biederman, kbuild-all, Linux Memory Management List, linuxppc-dev, linux-kernel, kexec On Thu, 19 May 2022 23:17:48 +0800 kernel test robot <lkp@intel.com> wrote: > Hi "Naveen, > > I love your patch! Yet something to improve: > > [auto build test ERROR on f993aed406eaf968ba3867a76bb46c95336a33d0] > > url: https://github.com/intel-lab-lkp/linux/commits/Naveen-N-Rao/kexec_file-Drop-weak-attribute-from-arch_kexec_apply_relocations-_add/20220519-171432 > base: f993aed406eaf968ba3867a76bb46c95336a33d0 > config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20220519/202205192320.CoXevcfR-lkp@intel.com/config) > compiler: s390-linux-gcc (GCC) 11.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/67171688c71cb5b05f26e0dfc45eec8d8d1428ff > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Naveen-N-Rao/kexec_file-Drop-weak-attribute-from-arch_kexec_apply_relocations-_add/20220519-171432 > git checkout 67171688c71cb5b05f26e0dfc45eec8d8d1428ff > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash arch/s390/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > In file included from arch/s390/kernel/machine_kexec_reloc.c:3: > >> arch/s390/include/asm/kexec.h:89:38: error: unknown type name 'Elf_Shdr'; did you mean 'elf_shdr'? > 89 | Elf_Shdr *section, > | ^~~~~~~~ > | elf_shdr > arch/s390/include/asm/kexec.h:90:44: error: unknown type name 'Elf_Shdr' > 90 | const Elf_Shdr *relsec, > | ^~~~~~~~ > arch/s390/include/asm/kexec.h:91:44: error: unknown type name 'Elf_Shdr' > 91 | const Elf_Shdr *symtab); > | ^~~~~~~~ Thanks, I did this: --- a/arch/s390/include/asm/kexec.h~kexec_file-drop-weak-attribute-from-arch_kexec_apply_relocations-fix +++ a/arch/s390/include/asm/kexec.h @@ -9,6 +9,8 @@ #ifndef _S390_KEXEC_H #define _S390_KEXEC_H +#include <linux/module.h> + #include <asm/processor.h> #include <asm/page.h> #include <asm/setup.h> _ ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-19 17:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220519091237.676736-1-naveen.n.rao@linux.vnet.ibm.com>
2022-05-19 15:17 ` [PATCH v2] kexec_file: Drop weak attribute from arch_kexec_apply_relocations[_add] kernel test robot
2022-05-19 17:29 ` Andrew Morton
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox