From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: <catalin.marinas@arm.com>, <will@kernel.org>,
<akpm@linux-foundation.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: <linux-mm@kvack.org>, <hch@infradead.org>, <arnd@arndb.de>,
<anshuman.khandual@arm.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH v3 4/6] mm: ioremap: Add arch_ioremap/iounmap()
Date: Thu, 19 May 2022 16:25:50 +0800 [thread overview]
Message-ID: <20220519082552.117736-5-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <20220519082552.117736-1-wangkefeng.wang@huawei.com>
Add special hook for architecture to verify or setup addr, size
or prot when ioremap() or iounmap(), which will make the generic
ioremap more useful.
arch_ioremap() return a pointer,
- IS_ERR means return an error
- NULL means continue to remap
- a non-NULL, non-IS_ERR pointer is directly returned
arch_iounmap() return a int value,
- 0 means continue to vunmap
- error code means skip vunmap and return directly
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
include/asm-generic/io.h | 24 ++++++++++++++++++++++++
mm/ioremap.c | 17 ++++++++++++++---
2 files changed, 38 insertions(+), 3 deletions(-)
diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h
index e6ffa2519f08..b60f7151e1d6 100644
--- a/include/asm-generic/io.h
+++ b/include/asm-generic/io.h
@@ -964,6 +964,30 @@ static inline void iounmap(volatile void __iomem *addr)
#elif defined(CONFIG_GENERIC_IOREMAP)
#include <linux/pgtable.h>
+/*
+ * Arch code can implement the following two special hooks when using GENERIC_IOREMAP
+ * arch_ioremap() return a pointer,
+ * - IS_ERR means return an error
+ * - NULL means continue to remap
+ * - a non-NULL, non-IS_ERR pointer is returned directly
+ * arch_iounmap() return a int,
+ * - 0 means continue to vunmap
+ * - error code means skip vunmap and return directly
+ */
+#ifndef arch_ioremap
+static inline void __iomem *arch_ioremap(phys_addr_t phys_addr, size_t size, unsigned long prot)
+{
+ return NULL;
+}
+#endif
+
+#ifndef arch_iounmap
+static inline int arch_iounmap(void __iomem *addr)
+{
+ return 0;
+}
+#endif
+
void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size, unsigned long prot);
void iounmap(volatile void __iomem *addr);
diff --git a/mm/ioremap.c b/mm/ioremap.c
index 7cb9996b0c12..fac7f23b8c4b 100644
--- a/mm/ioremap.c
+++ b/mm/ioremap.c
@@ -16,6 +16,7 @@ void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size, unsigned long pro
unsigned long offset, vaddr;
phys_addr_t last_addr;
struct vm_struct *area;
+ void __iomem *base;
/* Disallow wrap-around or zero size */
last_addr = phys_addr + size - 1;
@@ -27,8 +28,13 @@ void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size, unsigned long pro
phys_addr -= offset;
size = PAGE_ALIGN(size + offset);
- area = get_vm_area_caller(size, VM_IOREMAP,
- __builtin_return_address(0));
+ base = arch_ioremap(phys_addr, size, prot);
+ if (IS_ERR(base))
+ return NULL;
+ else if (base)
+ return base;
+
+ area = get_vm_area_caller(size, VM_IOREMAP, __builtin_return_address(0));
if (!area)
return NULL;
vaddr = (unsigned long)area->addr;
@@ -45,6 +51,11 @@ EXPORT_SYMBOL(ioremap_prot);
void iounmap(volatile void __iomem *addr)
{
- vunmap((void *)((unsigned long)addr & PAGE_MASK));
+ void __iomem *vaddr = (void __iomem *)((unsigned long)addr & PAGE_MASK);
+
+ if (arch_iounmap(vaddr))
+ return;
+
+ vunmap(vaddr);
}
EXPORT_SYMBOL(iounmap);
--
2.35.3
next prev parent reply other threads:[~2022-05-19 8:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 8:25 [PATCH v3 0/6] arm64: Cleanup ioremap() and support ioremap_prot() Kefeng Wang
2022-05-19 8:25 ` [PATCH v3 1/6] ARM: mm: kill unused runtime hook arch_iounmap() Kefeng Wang
2022-05-19 8:51 ` Anshuman Khandual
2022-05-20 15:28 ` Catalin Marinas
2022-05-24 2:03 ` Kefeng Wang
2022-05-21 20:30 ` Arnd Bergmann
2022-05-19 8:25 ` [PATCH v3 2/6] mm: ioremap: Use more sensibly name in ioremap_prot() Kefeng Wang
2022-05-19 8:25 ` [PATCH v3 3/6] mm: ioremap: Setup phys_addr of struct vm_struct Kefeng Wang
2022-05-19 8:25 ` Kefeng Wang [this message]
2022-05-19 18:52 ` [PATCH v3 4/6] mm: ioremap: Add arch_ioremap/iounmap() Andrew Morton
2022-05-20 1:22 ` Kefeng Wang
2022-05-23 3:57 ` Anshuman Khandual
2022-05-23 22:17 ` kernel test robot
2022-05-24 9:48 ` Kefeng Wang
2022-05-24 12:35 ` Arnd Bergmann
2022-05-24 14:31 ` Kefeng Wang
2022-05-24 12:37 ` Arnd Bergmann
2022-05-24 14:32 ` Kefeng Wang
2022-05-24 14:47 ` Arnd Bergmann
2022-05-24 14:53 ` Kefeng Wang
2022-05-31 6:13 ` Christoph Hellwig
2022-06-01 1:05 ` Kefeng Wang
2022-05-19 8:25 ` [PATCH v3 5/6] arm64: mm: Convert to GENERIC_IOREMAP Kefeng Wang
2022-05-19 8:25 ` [PATCH v3 6/6] arm64: Add HAVE_IOREMAP_PROT support Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519082552.117736-5-wangkefeng.wang@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=hch@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox