From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A20DC433EF for ; Wed, 18 May 2022 17:13:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE27A6B0072; Wed, 18 May 2022 13:13:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D91676B0073; Wed, 18 May 2022 13:13:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C59D46B0074; Wed, 18 May 2022 13:13:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B9D316B0072 for ; Wed, 18 May 2022 13:13:47 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 817E9797 for ; Wed, 18 May 2022 17:13:47 +0000 (UTC) X-FDA: 79479510894.01.A869439 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf24.hostedemail.com (Postfix) with ESMTP id 6DC95180101 for ; Wed, 18 May 2022 17:13:36 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 28AB8B8200E; Wed, 18 May 2022 17:13:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59C66C385A9; Wed, 18 May 2022 17:13:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1652894023; bh=9tQumf5hmMksHJMd0ddXQO4pdkF9lxtXV2d4XMaXLMg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1oFQORUH8huv1XWXl2XhwSl42RUHMTVMSUF7MmvBgM1HLhRrMGez+Fyr6OoiM2x+s jnKUKKp268ix7GKNohFVUZ0gACXAWGr0IQXMoQV2FPJw+yFPDX/v3BNy3B6zB0dgBH uhYm1Jy8z93pfIewz5emoCFiPAMatvkJ7i8n8VIw= Date: Wed, 18 May 2022 10:13:42 -0700 From: Andrew Morton To: Catalin Marinas Cc: Tong Tiangen , Will Deacon , Paul Walmsley , Palmer Dabbelt , Palmer Dabbelt , Albert Ou , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com, Guohanjun , Xie XiuQi , linux-mm@kvack.org Subject: Re: [PATCH -next 2/2] arm64/mm: fix page table check compile error for CONFIG_PGTABLE_LEVELS=2 Message-Id: <20220518101342.b1b17ab43331f31df33780ae@linux-foundation.org> In-Reply-To: References: <20220517074548.2227779-1-tongtiangen@huawei.com> <20220517074548.2227779-3-tongtiangen@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: tmukeybz7kpop5gd6fc3zg1ybdjjer31 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6DC95180101 X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=1oFQORUH; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-HE-Tag: 1652894016-642523 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 18 May 2022 17:28:38 +0100 Catalin Marinas wrote: > On Tue, May 17, 2022 at 07:45:48AM +0000, Tong Tiangen wrote: > > If CONFIG_PGTABLE_LEVELS=2 and CONFIG_ARCH_SUPPORTS_PAGE_TABLE_CHECK=y, > > then we trigger a compile error: > > > > error: implicit declaration of function 'pte_user_accessible_page' > > > > Move the definition of page table check helper out of branch > > CONFIG_PGTABLE_LEVELS > 2 > > > > Fixes: daf214c14dbe ("arm64/mm: enable ARCH_SUPPORTS_PAGE_TABLE_CHECK") > > Signed-off-by: Tong Tiangen > > I'd drop the fixes tag here since the patch is queued in the mm tree and > AFAIK that one doesn't have stable git commit ids. MM tree is at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Commit ID's are stable if a commit is in the mm-hotfixes-stable, mm-stable or mm-nonmm-stable branch. Commit ID's are unstable if a commit is still in the mm-hotfixes-unstable, mm-unstable or mm-unnonmm-stable. I move patches from -unstable to -stable after they're considered ready for it. The delay is very variable, depends on how things are coming along with that patch(set).