* Re: [PATCH -next 2/2] arm64/mm: fix page table check compile error for CONFIG_PGTABLE_LEVELS=2
[not found] ` <20220517074548.2227779-3-tongtiangen@huawei.com>
@ 2022-05-18 16:28 ` Catalin Marinas
2022-05-18 17:13 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Catalin Marinas @ 2022-05-18 16:28 UTC (permalink / raw)
To: Tong Tiangen
Cc: Will Deacon, Paul Walmsley, Palmer Dabbelt, Palmer Dabbelt,
Albert Ou, Arnd Bergmann, linux-arm-kernel, linux-riscv,
linux-arch, linux-kernel, wangkefeng.wang, Guohanjun, Xie XiuQi,
linux-mm, Andrew Morton
On Tue, May 17, 2022 at 07:45:48AM +0000, Tong Tiangen wrote:
> If CONFIG_PGTABLE_LEVELS=2 and CONFIG_ARCH_SUPPORTS_PAGE_TABLE_CHECK=y,
> then we trigger a compile error:
>
> error: implicit declaration of function 'pte_user_accessible_page'
>
> Move the definition of page table check helper out of branch
> CONFIG_PGTABLE_LEVELS > 2
>
> Fixes: daf214c14dbe ("arm64/mm: enable ARCH_SUPPORTS_PAGE_TABLE_CHECK")
> Signed-off-by: Tong Tiangen <tongtiangen@huawei.com>
I'd drop the fixes tag here since the patch is queued in the mm tree and
AFAIK that one doesn't have stable git commit ids. Otherwise:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
(I cc'ed Andrew and linux-mm as Andrew queued the original patches)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next 2/2] arm64/mm: fix page table check compile error for CONFIG_PGTABLE_LEVELS=2
2022-05-18 16:28 ` [PATCH -next 2/2] arm64/mm: fix page table check compile error for CONFIG_PGTABLE_LEVELS=2 Catalin Marinas
@ 2022-05-18 17:13 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2022-05-18 17:13 UTC (permalink / raw)
To: Catalin Marinas
Cc: Tong Tiangen, Will Deacon, Paul Walmsley, Palmer Dabbelt,
Palmer Dabbelt, Albert Ou, Arnd Bergmann, linux-arm-kernel,
linux-riscv, linux-arch, linux-kernel, wangkefeng.wang,
Guohanjun, Xie XiuQi, linux-mm
On Wed, 18 May 2022 17:28:38 +0100 Catalin Marinas <catalin.marinas@arm.com> wrote:
> On Tue, May 17, 2022 at 07:45:48AM +0000, Tong Tiangen wrote:
> > If CONFIG_PGTABLE_LEVELS=2 and CONFIG_ARCH_SUPPORTS_PAGE_TABLE_CHECK=y,
> > then we trigger a compile error:
> >
> > error: implicit declaration of function 'pte_user_accessible_page'
> >
> > Move the definition of page table check helper out of branch
> > CONFIG_PGTABLE_LEVELS > 2
> >
> > Fixes: daf214c14dbe ("arm64/mm: enable ARCH_SUPPORTS_PAGE_TABLE_CHECK")
> > Signed-off-by: Tong Tiangen <tongtiangen@huawei.com>
>
> I'd drop the fixes tag here since the patch is queued in the mm tree and
> AFAIK that one doesn't have stable git commit ids.
MM tree is at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Commit ID's are stable if a commit is in the mm-hotfixes-stable,
mm-stable or mm-nonmm-stable branch.
Commit ID's are unstable if a commit is still in the
mm-hotfixes-unstable, mm-unstable or mm-unnonmm-stable.
I move patches from -unstable to -stable after they're considered ready
for it. The delay is very variable, depends on how things are coming
along with that patch(set).
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-18 17:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220517074548.2227779-1-tongtiangen@huawei.com>
[not found] ` <20220517074548.2227779-3-tongtiangen@huawei.com>
2022-05-18 16:28 ` [PATCH -next 2/2] arm64/mm: fix page table check compile error for CONFIG_PGTABLE_LEVELS=2 Catalin Marinas
2022-05-18 17:13 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox