From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A61E0C433EF for ; Wed, 18 May 2022 07:31:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28EBA6B0074; Wed, 18 May 2022 03:31:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23E246B0075; Wed, 18 May 2022 03:31:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12DB18D0001; Wed, 18 May 2022 03:31:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 043C16B0074 for ; Wed, 18 May 2022 03:31:28 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D665020493 for ; Wed, 18 May 2022 07:31:27 +0000 (UTC) X-FDA: 79478043414.16.14F8F4C Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by imf18.hostedemail.com (Postfix) with ESMTP id A89F51C00C4 for ; Wed, 18 May 2022 07:31:13 +0000 (UTC) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1652859085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0EM8qsmNmS7Fmz5qE3a96NkBQN0Ii+hZn5vOwarbKn4=; b=ZPPC2sJYFuvhdqM0vfp208YXjcdLLZsppji7padQixjCxYiPNVUvCHUffOtED3HZQJ5JRN ita2SttPSqW9kSGzajkJvNfuAQfYuBJ6gkY4lWvJQtqTJIvylGcJyr6+rbubcQcSNH+9CD ntG2sqftHW0/FpKrkXFqPBAItlOLw5o= From: Jackie Liu To: elver@google.com Cc: glider@google.com, liu.yun@linux.dev, dvyukov@google.com, kasan-dev@googlegroups.com, linux-mm@kvack.org Subject: [PATCH v4] mm/kfence: print disabling or re-enabling message Date: Wed, 18 May 2022 15:31:05 +0800 Message-Id: <20220518073105.3160335-1-liu.yun@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Stat-Signature: a9gttnpmaqx57ncshipyd5higwccotzn Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZPPC2sJY; spf=pass (imf18.hostedemail.com: domain of liu.yun@linux.dev designates 91.121.223.63 as permitted sender) smtp.mailfrom=liu.yun@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A89F51C00C4 X-HE-Tag: 1652859073-75258 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Jackie Liu By printing information, we can friendly prompt the status change information of kfence by dmesg and record by syslog. Also, set kfence_enabled to false only when needed. Co-developed-by: Marco Elver Signed-off-by: Jackie Liu --- v1->v2: fixup by Marco Elver v2->v3: write kfence_enabled=false only true before v3->v4: cleanup mm/kfence/core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mm/kfence/core.c b/mm/kfence/core.c index 11a954763be9..af0489d4d149 100644 --- a/mm/kfence/core.c +++ b/mm/kfence/core.c @@ -67,8 +67,11 @@ static int param_set_sample_interval(const char *val, const struct kernel_param if (ret < 0) return ret; - if (!num) /* Using 0 to indicate KFENCE is disabled. */ + /* Using 0 to indicate KFENCE is disabled. */ + if (!num && READ_ONCE(kfence_enabled)) { + pr_info("disabled\n"); WRITE_ONCE(kfence_enabled, false); + } *((unsigned long *)kp->arg) = num; @@ -874,6 +877,7 @@ static int kfence_enable_late(void) WRITE_ONCE(kfence_enabled, true); queue_delayed_work(system_unbound_wq, &kfence_timer, 0); + pr_info("re-enabled\n"); return 0; } -- 2.25.1