From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Matthew Wilcox <willy@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, John Dias <joaodias@google.com>,
Tim Murray <timmurray@google.com>,
Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH] mm: don't be stuck to rmap lock on reclaim path
Date: Tue, 17 May 2022 16:58:54 -0700 [thread overview]
Message-ID: <20220517165854.fa6810576db304428b275385@linux-foundation.org> (raw)
In-Reply-To: <YnNqeB5tUf6LZ57b@google.com>
On Wed, 4 May 2022 23:11:04 -0700 Minchan Kim <minchan@kernel.org> wrote:
> > > +
> > > + static struct rmap_walk_control rwc = {
> > > .rmap_one = page_idle_clear_pte_refs_one,
> > > .anon_lock = folio_lock_anon_vma_read,
> > > };
>
> So, delta is
--- a/mm/page_idle.c~mm-dont-be-stuck-to-rmap-lock-on-reclaim-path-fix
+++ a/mm/page_idle.c
@@ -87,6 +87,10 @@ static void page_idle_clear_pte_refs(str
{
struct folio *folio = page_folio(page);
+ /*
+ * Since rwc.try_lock is unused, rwc is effectively immutable, so we
+ * can make it static to save some cycles and stack.
+ */
static struct rmap_walk_control rwc = {
.rmap_one = page_idle_clear_pte_refs_one,
.anon_lock = folio_lock_anon_vma_read,
_
and with that, I believe this change is good to be imported into mm-stable
later this week.
prev parent reply other threads:[~2022-05-17 23:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 17:03 Minchan Kim
2022-05-04 2:13 ` kernel test robot
2022-05-04 3:24 ` kernel test robot
2022-05-04 3:32 ` Matthew Wilcox
2022-05-04 4:30 ` Minchan Kim
2022-05-04 6:09 ` Matthew Wilcox
2022-05-04 15:52 ` Minchan Kim
2022-05-04 16:55 ` Matthew Wilcox
2022-05-04 23:47 ` Minchan Kim
2022-05-05 0:42 ` Matthew Wilcox
2022-05-05 6:11 ` Minchan Kim
2022-05-17 23:58 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517165854.fa6810576db304428b275385@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=joaodias@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=surenb@google.com \
--cc=timmurray@google.com \
--cc=vdavydov.dev@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox