From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C33DC433EF for ; Tue, 17 May 2022 11:14:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 921B96B0073; Tue, 17 May 2022 07:14:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D14C6B0074; Tue, 17 May 2022 07:14:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79A506B0075; Tue, 17 May 2022 07:14:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6B6196B0073 for ; Tue, 17 May 2022 07:14:51 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DD8E220A10 for ; Tue, 17 May 2022 11:14:50 +0000 (UTC) X-FDA: 79474977540.01.0EA5D46 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf07.hostedemail.com (Postfix) with ESMTP id 11036400C0 for ; Tue, 17 May 2022 11:14:41 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 51B4D1F383; Tue, 17 May 2022 11:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1652786088; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yA+3NgBf3IrpMWWgGDxlwJ/B12UU7TeQ4+mIhyTdo/w=; b=EsnrGk4LGgGW4gH6NhxulNpyVbPhOUhrK7XBH390IIvHalNrRGPskDOCmKyJZ7TqXBLFf5 dOlICJaxM0omjE8nCLU/0Y4+MlE1eoqAwtfwFkmNfhUJeet4Ct8wQ1kY+/VWEjbRb1VqB/ EYo8b/RRtTAfSRyLnXgI9KKyVi9iJK4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1652786088; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yA+3NgBf3IrpMWWgGDxlwJ/B12UU7TeQ4+mIhyTdo/w=; b=+SUXYUymaY7d3Y4hn5yYLYxdt5z4zyefgezKKodncu/m1PKzpiRSRv6J8QhHA1/e0mcBIN BszDOF4oxq/q5vCw== Received: from quack3.suse.cz (unknown [10.163.43.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 260612C141; Tue, 17 May 2022 11:14:48 +0000 (UTC) Received: by quack3.suse.cz (Postfix, from userid 1000) id 97AB4A0631; Tue, 17 May 2022 13:14:47 +0200 (CEST) Date: Tue, 17 May 2022 13:14:47 +0200 From: Jan Kara To: Stefan Roesch Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz Subject: Re: [RFC PATCH v2 04/16] iomap: add async buffered write support Message-ID: <20220517111447.bzzmdbmx6cebnugc@quack3.lan> References: <20220516164718.2419891-1-shr@fb.com> <20220516164718.2419891-5-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220516164718.2419891-5-shr@fb.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 11036400C0 X-Stat-Signature: 1a3b83ari7gwck9o5dzucd593mfe6m7u X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EsnrGk4L; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+SUXYUym; spf=pass (imf07.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none X-HE-Tag: 1652786081-928045 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 16-05-22 09:47:06, Stefan Roesch wrote: > This adds async buffered write support to iomap. The support is focused > on the changes necessary to support XFS with iomap. > > Support for other filesystems might require additional changes. > > Signed-off-by: Stefan Roesch > --- > fs/iomap/buffered-io.c | 21 ++++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index 1ffdc7078e7d..ceb3091f94c2 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -580,13 +580,20 @@ static int __iomap_write_begin(const struct iomap_iter *iter, loff_t pos, > size_t from = offset_in_folio(folio, pos), to = from + len; > size_t poff, plen; > gfp_t gfp = GFP_NOFS | __GFP_NOFAIL; > + bool no_wait = (iter->flags & IOMAP_NOWAIT); > + > + if (no_wait) > + gfp = GFP_NOIO; GFP_NOIO means that direct reclaim is still allowed. Not sure whether you want to enter direct reclaim from io_uring fast path because in theory that can still sleep. GFP_NOWAIT would be a more natural choice... Honza -- Jan Kara SUSE Labs, CR