From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A73AC433F5 for ; Mon, 16 May 2022 20:55:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CB646B0072; Mon, 16 May 2022 16:55:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67B186B0073; Mon, 16 May 2022 16:55:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 543026B0074; Mon, 16 May 2022 16:55:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 446216B0072 for ; Mon, 16 May 2022 16:55:43 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 1BDBA6138D for ; Mon, 16 May 2022 20:55:43 +0000 (UTC) X-FDA: 79472812566.18.5CCB6EA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 5C7321A003E for ; Mon, 16 May 2022 20:55:30 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7B32C61295; Mon, 16 May 2022 20:55:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B30F4C385AA; Mon, 16 May 2022 20:55:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1652734538; bh=dugUPCYBgA8+hGXd7VCk99Ywg4RL56xDXuN95GI3f/I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=t9V8Kfrs85wyXWugBWf5HDM27Y6DeGms/QxZ1q5i5X/PCQKUDDyIqaquN6GAXPrgW BCay57CEkeaCYfJdDFFkdHZrOhbBzwFb9S3P1smqgWsF7ww2x4F+3Pc7S/I6xHCaZG d6hXl9Avj6g05HfnpMJ119E9h2abFZez1H1ASETM= Date: Mon, 16 May 2022 13:55:37 -0700 From: Andrew Morton To: Vasily Averin Cc: kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Steven Rostedt Subject: Re: [PATCH mm v2] tracing: incorrect gfp_t conversion Message-Id: <20220516135537.8458fe08464d97bb45684252@linux-foundation.org> In-Reply-To: <20220515180903.37fc18e4@gandalf.local.home> References: <20220515180903.37fc18e4@gandalf.local.home> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 5C7321A003E X-Stat-Signature: hpjwppwz35gw7joa6zijihiar8qnpszk Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=t9V8Kfrs; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1652734530-452093 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 11 May 2022 10:20:39 +0300 Vasily Averin wrote: > Fixes the following sparse warnings: > > include/trace/events/*: sparse: cast to restricted gfp_t > include/trace/events/*: sparse: restricted gfp_t degrades to integer > > gfp_t type is bitwise and requires __force attributes for any casts. I already moved the previous version into mm-stable. Would prefer not to have to rebase it. > v2: 1) re-based to 5.18-rc6 > 2) re-defined __def_gfpflag_names array according to > akpm@, willy@ and Joe Perches recommendations Please redo this against the mm-stable or mm-unstable branches against git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm, or against your own previous version. The new patch will simply switch to the gfpflag_string() trick, so it will not be a "fix", so please let's position it as a "cleanup".