* [PATCH] mm/page_owner.c: Add missing __initdata attribute
@ 2022-05-16 3:00 bh1scw
2022-05-16 3:41 ` Muchun Song
0 siblings, 1 reply; 2+ messages in thread
From: bh1scw @ 2022-05-16 3:00 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, linux-mm, Fanjun Kong, Muchun Song
From: Fanjun Kong <bh1scw@gmail.com>
This patch fix two issues:
1. Add __initdata attribute according to include/linux/init.h:
> For initialized data:
> You should insert __initdata between the variable name and equal
> sign followed by value
2. Fix below error reported by checkpatch.pl:
ERROR: do not initialise statics to false
Special thanks to Muchun Song :)
Suggested-by: Muchun Song <songmuchun@bytedance.com>
Signed-off-by: Fanjun Kong <bh1scw@gmail.com>
---
mm/page_owner.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_owner.c b/mm/page_owner.c
index 9185ff4eacb6..e4c6f3f1695b 100644
--- a/mm/page_owner.c
+++ b/mm/page_owner.c
@@ -34,7 +34,7 @@ struct page_owner {
pid_t tgid;
};
-static bool page_owner_enabled = false;
+static bool page_owner_enabled __initdata;
DEFINE_STATIC_KEY_FALSE(page_owner_inited);
static depot_stack_handle_t dummy_handle;
--
2.36.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mm/page_owner.c: Add missing __initdata attribute
2022-05-16 3:00 [PATCH] mm/page_owner.c: Add missing __initdata attribute bh1scw
@ 2022-05-16 3:41 ` Muchun Song
0 siblings, 0 replies; 2+ messages in thread
From: Muchun Song @ 2022-05-16 3:41 UTC (permalink / raw)
To: bh1scw; +Cc: Andrew Morton, LKML, Linux Memory Management List
On Mon, May 16, 2022 at 11:09 AM <bh1scw@gmail.com> wrote:
>
> From: Fanjun Kong <bh1scw@gmail.com>
>
> This patch fix two issues:
> 1. Add __initdata attribute according to include/linux/init.h:
> > For initialized data:
> > You should insert __initdata between the variable name and equal
> > sign followed by value
>
> 2. Fix below error reported by checkpatch.pl:
> ERROR: do not initialise statics to false
>
> Special thanks to Muchun Song :)
>
> Suggested-by: Muchun Song <songmuchun@bytedance.com>
> Signed-off-by: Fanjun Kong <bh1scw@gmail.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-16 3:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16 3:00 [PATCH] mm/page_owner.c: Add missing __initdata attribute bh1scw
2022-05-16 3:41 ` Muchun Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox