From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 054A6C433F5 for ; Fri, 13 May 2022 23:10:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88E296B0073; Fri, 13 May 2022 19:10:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83D836B0075; Fri, 13 May 2022 19:10:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DE5F6B0078; Fri, 13 May 2022 19:10:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6155F6B0073 for ; Fri, 13 May 2022 19:10:09 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3022C31B29 for ; Fri, 13 May 2022 23:10:09 +0000 (UTC) X-FDA: 79462264938.24.05D0D5B Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf11.hostedemail.com (Postfix) with ESMTP id AD99A400B5 for ; Fri, 13 May 2022 23:09:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652483405; x=1684019405; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=AmRezgHHEdw2JBZ1v9lIr+kT3Im+6xmk5HtIS/CA1Mc=; b=kIWWQcbQTFPp6pW2nIynGXIaA77+Ffy93YM/5Nsl9Z/5Ws8e6aegcIrf uqaHDDhKETvVzFZDXxSbRDnJ1/c+kpSwJjTr+l5sqhzypEr4K3XAe6YM6 3BwP55E6H2UR53FL2hWTNZvx9D4JQBKXVeIFr7VrBExRxtOGS3kSuq/T5 ez02QRJ8sVXALY9bbZvI/2MCOkrWXGRiS1/qalbJGarMHuSxVfJH28HCn 3Rb9Y6/hftm/n1aMQXew7fsXPoCvzMALnTJXGCAOYHuVdp/hLzF04xTTp lsYSuwMSQV/smK+Lv34XE2tVJLs4y6fSaQb2WKPjrrFzfBzfelS8z2B8U A==; X-IronPort-AV: E=McAfee;i="6400,9594,10346"; a="270103854" X-IronPort-AV: E=Sophos;i="5.91,223,1647327600"; d="scan'208";a="270103854" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2022 16:10:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,223,1647327600"; d="scan'208";a="740373181" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 13 May 2022 16:10:00 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id 08838A8; Sat, 14 May 2022 02:09:58 +0300 (EEST) Date: Sat, 14 May 2022 02:09:58 +0300 From: "Kirill A. Shutemov" To: "Edgecombe, Rick P" Cc: "glider@google.com" , "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "hjl.tools@gmail.com" , "linux-mm@kvack.org" , "dave.hansen@linux.intel.com" , "aryabinin@virtuozzo.com" , "dvyukov@google.com" , "x86@kernel.org" , "ak@linux.intel.com" , "Lutomirski, Andy" Subject: Re: [RFCv2 03/10] x86: Introduce userspace API to handle per-thread features Message-ID: <20220513230958.dbxp6m3y3lnq74qb@black.fi.intel.com> References: <20220511022751.65540-1-kirill.shutemov@linux.intel.com> <20220511022751.65540-5-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: AD99A400B5 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=kIWWQcbQ; spf=none (imf11.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-Stat-Signature: ta71uy4r3ydyddzb1ztbt186q4cbxqbo X-HE-Tag: 1652483399-258958 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 13, 2022 at 05:34:12PM +0000, Edgecombe, Rick P wrote: > On Fri, 2022-05-13 at 16:09 +0200, Alexander Potapenko wrote: > > > + > > > + /* Handle ARCH_THREAD_FEATURE_ENABLE */ > > > + > > > + task->thread.features |= features; > > > +out: > > > + return task->thread.features; > > > > Isn't arch_prctl() supposed to return 0 on success? > > Hmm, good point. Maybe we'll need a struct to pass info in and out. But values >0 are unused. I don't see why can't we use them. -- Kirill A. Shutemov