From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF5B0C433FE for ; Fri, 13 May 2022 02:58:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6449C6B0073; Thu, 12 May 2022 22:58:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F36B6B0075; Thu, 12 May 2022 22:58:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BCFA6B0078; Thu, 12 May 2022 22:58:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 38EDC6B0073 for ; Thu, 12 May 2022 22:58:08 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7AC08327C5 for ; Fri, 13 May 2022 02:58:06 +0000 (UTC) X-FDA: 79459210572.30.1AC8F84 Received: from mail.nfschina.com (unknown [124.16.136.209]) by imf19.hostedemail.com (Postfix) with ESMTP id 376301A00B3 for ; Fri, 13 May 2022 02:57:55 +0000 (UTC) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id 6C2B51E80C82; Fri, 13 May 2022 10:52:20 +0800 (CST) X-Virus-Scanned: amavisd-new at test.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (mail.nfschina.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PaVTrAFpiRlA; Fri, 13 May 2022 10:52:17 +0800 (CST) Received: from localhost.localdomain.localdomain (unknown [219.141.250.2]) (Authenticated sender: xupengfei@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id A27F71E80C80; Fri, 13 May 2022 10:52:17 +0800 (CST) From: XU pengfei To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kernel@nfschina.com, Xu Pengfei Subject: [PATCH] mm: Optimize the statement to make it clearer Date: Fri, 13 May 2022 10:57:54 +0800 Message-Id: <20220513025754.9230-1-xupengfei@nfschina.com> X-Mailer: git-send-email 2.18.2 X-Stat-Signature: y1uzg59qkw1346axgpgh4c9j36ks8ojb X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 376301A00B3 X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=none; spf=none (imf19.hostedemail.com: domain of xupengfei@nfschina.com has no SPF policy when checking 124.16.136.209) smtp.mailfrom=xupengfei@nfschina.com; dmarc=none X-HE-Tag: 1652410675-304644 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Xu Pengfei Optimize the statement to make it clearer Signed-off-by: Xu Pengfei --- mm/filemap.c | 4 ++-- mm/mmap.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 9a1eef6c5d35..f6b2b915052a 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1374,9 +1374,9 @@ static inline int folio_wait_bit_common(struct folio *folio, int bit_nr, * waiter, but an exclusive one requires WQ_FLAG_DONE. */ if (behavior == EXCLUSIVE) - return wait->flags & WQ_FLAG_DONE ? 0 : -EINTR; + return (wait->flags & WQ_FLAG_DONE) ? 0 : -EINTR; - return wait->flags & WQ_FLAG_WOKEN ? 0 : -EINTR; + return (wait->flags & WQ_FLAG_WOKEN) ? 0 : -EINTR; } #ifdef CONFIG_MIGRATION diff --git a/mm/mmap.c b/mm/mmap.c index 3aa839f81e63..28196b93515a 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -2975,9 +2975,9 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size, goto out; } - prot |= vma->vm_flags & VM_READ ? PROT_READ : 0; - prot |= vma->vm_flags & VM_WRITE ? PROT_WRITE : 0; - prot |= vma->vm_flags & VM_EXEC ? PROT_EXEC : 0; + prot |= (vma->vm_flags & VM_READ) ? PROT_READ : 0; + prot |= (vma->vm_flags & VM_WRITE) ? PROT_WRITE : 0; + prot |= (vma->vm_flags & VM_EXEC) ? PROT_EXEC : 0; flags &= MAP_NONBLOCK; flags |= MAP_SHARED | MAP_FIXED | MAP_POPULATE; -- 2.18.2