linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: maobibo <maobibo@loongson.cn>
Cc: Peter Xu <peterx@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Yang Shi <shy828301@gmail.com>
Subject: Re: [PATCH v3] mm/khugepaged: sched to numa node when collapse huge page
Date: Thu, 12 May 2022 18:49:08 -0700	[thread overview]
Message-ID: <20220512184908.0852e1efcb6fd78aea52b557@linux-foundation.org> (raw)
In-Reply-To: <69c4f018-2012-8af5-569b-289d2a8a80f5@loongson.cn>

On Fri, 13 May 2022 09:29:07 +0800 maobibo <maobibo@loongson.cn> wrote:

> 
> 
> >> and/or changelogging.
> > Sorry for the late response, the mail is filtered and I did not notice that. The result is not so obvious after bandwidth is improved between nodes, it is only about 1% improvement for specint2006 for 32 core on my box.
> > 
> > Now I do not see negative effective about this patch unless user wants to keep some cores separated from khugepaged daemon process.
> 
> Can we provide an extra parameter to let khugepaged daemon scheduling binded to node or freely? If can, I will provide updated patch.

It has always surprised me that we have a single khugepaged thread.  If
we had a thread per node, you'd be all fixed up, yes?

Ditto ksmd.



  reply	other threads:[~2022-05-13  1:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-17  6:50 Bibo Mao
2022-04-27 20:48 ` Andrew Morton
2022-04-27 22:29   ` Yang Shi
2022-04-28 10:07   ` David Hildenbrand
2022-04-28 13:50 ` Peter Xu
2022-04-28 15:17 ` David Hildenbrand
2022-04-28 16:34   ` Peter Xu
2022-05-13  0:36     ` Andrew Morton
2022-05-13  1:19       ` maobibo
2022-05-13  1:29         ` maobibo
2022-05-13  1:49           ` Andrew Morton [this message]
2022-05-13  1:59             ` maobibo
2022-05-13  2:40             ` Yang Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220512184908.0852e1efcb6fd78aea52b557@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maobibo@loongson.cn \
    --cc=peterx@redhat.com \
    --cc=shy828301@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox