From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 862B1C433EF for ; Thu, 12 May 2022 17:44:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE69D6B0074; Thu, 12 May 2022 13:44:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E964B6B0075; Thu, 12 May 2022 13:44:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D861A6B0078; Thu, 12 May 2022 13:44:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CACAF6B0074 for ; Thu, 12 May 2022 13:44:55 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9B1CE999 for ; Thu, 12 May 2022 17:44:55 +0000 (UTC) X-FDA: 79457816550.20.3007EB8 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf27.hostedemail.com (Postfix) with ESMTP id BD319400A9 for ; Thu, 12 May 2022 17:44:52 +0000 (UTC) Received: by mail-qv1-f44.google.com with SMTP id p3so4914577qvi.7 for ; Thu, 12 May 2022 10:44:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=dZue0UTlrDAnzvGcVBrv1iRqhh3n5waeAxQ9q+USOtQ=; b=W4MPTIRZHXuUC+9anqBarFLt9WHYJmjwarlYiuY3d3yYsNG2llqwQfrO37CJK/XilR +PhG7gH48cmARUTgm+47TmF7zsjszgTAEz279k/FcmkUIO96rgZnNBgRqjwLWLm1GWtK //EU1+XB9AUjzi0tL5JEV7pOaGUF8rsddeu+d3Xzxt/0McWXNJ65XN5bFHwXIFK5A6sE Qvx6yZIrQ+qwDzlI2vdg7Aum5dX/e83v5/Bd9pwjyYs/2lJgCRHcFZeGCEtnOPgu/Evt Arlw5fEXbADgjdZemj8ZJ6TIwqZo/x5NgbjOw9/kwgBFLffIpWWieCZPjUSn5CmIJ8gk 2n2A== X-Gm-Message-State: AOAM530KllGHU0LWMYsRhwlKJ3wK7/gYvDv+aTeOBaBR+dy0v9aQH+oL gQRoAYnP2KsrN0j3O9yky14= X-Google-Smtp-Source: ABdhPJywll+nIbOZcCNCeFmLnIqwiQprWlxHUY6UCR89jqS67IVxJjUv50+ELL2s5a/gSS3T90c1ZA== X-Received: by 2002:a05:6214:b11:b0:456:446e:a6c1 with SMTP id u17-20020a0562140b1100b00456446ea6c1mr888381qvj.28.1652377494352; Thu, 12 May 2022 10:44:54 -0700 (PDT) Received: from dev0025.ash9.facebook.com (fwdproxy-ash-013.fbsv.net. [2a03:2880:20ff:d::face:b00c]) by smtp.gmail.com with ESMTPSA id fu37-20020a05622a5da500b002f39b99f67bsm121960qtb.21.2022.05.12.10.44.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 10:44:54 -0700 (PDT) Date: Thu, 12 May 2022 10:44:52 -0700 From: David Vernet To: Michal =?utf-8?Q?Koutn=C3=BD?= Cc: akpm@linux-foundation.org, tj@kernel.org, roman.gushchin@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, kernel-team@fb.com Subject: Re: [PATCH v2 0/5] Fix bugs in memcontroller cgroup tests Message-ID: <20220512174452.tr34tuh4k5jm6qjs@dev0025.ash9.facebook.com> References: <20220423155619.3669555-1-void@manifault.com> <20220512170410.GA16096@blackbody.suse.cz> <20220512173018.3pqlfwfigbbkoh4u@dev0025.ash9.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220512173018.3pqlfwfigbbkoh4u@dev0025.ash9.facebook.com> User-Agent: NeoMutt/20211029 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BD319400A9 X-Stat-Signature: oe7fxu9wm5fuzu1hy1jt4khy1k51k53f X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of dcvernet@gmail.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=dcvernet@gmail.com X-HE-Tag: 1652377492-833317 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 12, 2022 at 10:30:18AM -0700, David Vernet wrote: > Hi Michal, > > On Thu, May 12, 2022 at 07:04:10PM +0200, Michal Koutný wrote: > > Are the Roman's patches merged anywhere? (I ran into some issues when I > > was rebasing your (David's) series on top of master.) I'd like to put > > all sensible patches in one series or stack on existing branch (if > > there's any). > > Roman's patches are present on master on the linux-mm tree. See > b7dbfd6553d..a131b1ed12c6. > > > For possible v3 of this series, I did: > > - dropped the patch that allows non-zero memory.events:low for a sibling with > > memory.low=0 when mounted with memory_recursiveprot (the case needs more > > discussion), > > Ack, and thanks for keeping us steered in the right direction here. I don't > see this in the patch set you linked, but I agree this commit should be > reverted and the reclaim logic instead fixed. > > > - added few more cleanups, convenience for debugging, > > Are you referring to the FAIL() macro you added? I would love to Ack that, > but unfortunately checkpatch.pl will probably yell at you for having a goto > in that macro, per the point about avoiding macros that affect control flow > [0]. > > I tried to do the same thing when sending out my patch set and had to > revert it before sending it to upstream. > > Thanks, > David > > [0] https://github.com/Werkov/linux/commit/a076339cc4825af2f22f58c1347a572b104b8221 Sorry, I meant to link this: https://www.kernel.org/doc/html/latest/process/coding-style.html#macros-enums-and-rtl