From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17D09C4332F for ; Thu, 12 May 2022 17:30:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D8466B0074; Thu, 12 May 2022 13:30:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 887146B0075; Thu, 12 May 2022 13:30:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 776096B0078; Thu, 12 May 2022 13:30:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6A5C16B0074 for ; Thu, 12 May 2022 13:30:22 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 440DC1207EA for ; Thu, 12 May 2022 17:30:22 +0000 (UTC) X-FDA: 79457779884.17.6CFB8F8 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf07.hostedemail.com (Postfix) with ESMTP id 16861400AC for ; Thu, 12 May 2022 17:30:14 +0000 (UTC) Received: by mail-qk1-f174.google.com with SMTP id w3so5307886qkb.3 for ; Thu, 12 May 2022 10:30:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=HgIdbY+Ecvji+T/cCG5mM6Y68lgt4DMV4FLsZ7Ccutw=; b=8FjHsfI7frjElQHlXFRI4taE0wHMII/HL+pw4vsUWBpEaGf0BPONehu7fscWGtuc1G C12oRU+KptTa8aKYzBpVm9AgHkQ/RWHo0ZgmsMAzBMVai7yA2exOglIDpFczcwZU1ye6 VqaqtPSkddLoamXCuayMT2VSiucXSquqHXiEYmltjAbZ8KJvDghbuN9uV7muiVGtOwHD FavDXmhICqSTbs9Tv+PhnxlCPKXFz5e3JoQyyT8YqgAuLRjwYoXEZDexvE6X3rCxOFP9 RauCFF+qWXhGySk5Z6jO180FxrpotxfeJnxoAWiRsKl7ojOeOM+9eqJ+f6iDD4Jd8XQg gqMg== X-Gm-Message-State: AOAM533G7/DUCgj9V7AcoReviytOaABeUa1ne5sXssGHst50T7PZNkgo u0ZwFKaO1kl8RXWlfyXjJME= X-Google-Smtp-Source: ABdhPJx6sw+zCIzg+CqDUHiaFwLzww+u+emudlIyVK/dv1n1pC2Ki/A0zrTYo+0UVea2Q6VQFp53vg== X-Received: by 2002:a05:620a:993:b0:6a0:1dca:5a70 with SMTP id x19-20020a05620a099300b006a01dca5a70mr765762qkx.543.1652376620808; Thu, 12 May 2022 10:30:20 -0700 (PDT) Received: from dev0025.ash9.facebook.com (fwdproxy-ash-018.fbsv.net. [2a03:2880:20ff:12::face:b00c]) by smtp.gmail.com with ESMTPSA id v22-20020a05620a441600b0069fc13ce1e7sm58975qkp.24.2022.05.12.10.30.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 10:30:20 -0700 (PDT) Date: Thu, 12 May 2022 10:30:18 -0700 From: David Vernet To: Michal =?utf-8?Q?Koutn=C3=BD?= Cc: akpm@linux-foundation.org, tj@kernel.org, roman.gushchin@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, kernel-team@fb.com Subject: Re: [PATCH v2 0/5] Fix bugs in memcontroller cgroup tests Message-ID: <20220512173018.3pqlfwfigbbkoh4u@dev0025.ash9.facebook.com> References: <20220423155619.3669555-1-void@manifault.com> <20220512170410.GA16096@blackbody.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220512170410.GA16096@blackbody.suse.cz> User-Agent: NeoMutt/20211029 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 16861400AC Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of dcvernet@gmail.com designates 209.85.222.174 as permitted sender) smtp.mailfrom=dcvernet@gmail.com; dmarc=none X-Rspam-User: X-Stat-Signature: cp8nh4t1bi3zcjfibrhd8u3dzs1eok4p X-HE-Tag: 1652376614-545429 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Michal, On Thu, May 12, 2022 at 07:04:10PM +0200, Michal Koutný wrote: > Are the Roman's patches merged anywhere? (I ran into some issues when I > was rebasing your (David's) series on top of master.) I'd like to put > all sensible patches in one series or stack on existing branch (if > there's any). Roman's patches are present on master on the linux-mm tree. See b7dbfd6553d..a131b1ed12c6. > For possible v3 of this series, I did: > - dropped the patch that allows non-zero memory.events:low for a sibling with > memory.low=0 when mounted with memory_recursiveprot (the case needs more > discussion), Ack, and thanks for keeping us steered in the right direction here. I don't see this in the patch set you linked, but I agree this commit should be reverted and the reclaim logic instead fixed. > - added few more cleanups, convenience for debugging, Are you referring to the FAIL() macro you added? I would love to Ack that, but unfortunately checkpatch.pl will probably yell at you for having a goto in that macro, per the point about avoiding macros that affect control flow [0]. I tried to do the same thing when sending out my patch set and had to revert it before sending it to upstream. Thanks, David [0] https://github.com/Werkov/linux/commit/a076339cc4825af2f22f58c1347a572b104b8221