From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1E09C433F5 for ; Wed, 11 May 2022 20:43:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EE8C6B0074; Wed, 11 May 2022 16:43:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2769B6B0075; Wed, 11 May 2022 16:43:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1178C6B0078; Wed, 11 May 2022 16:43:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F22E26B0074 for ; Wed, 11 May 2022 16:43:25 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BB26C331CA for ; Wed, 11 May 2022 20:43:25 +0000 (UTC) X-FDA: 79454637570.20.393D0DA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 7F53E1C00A2 for ; Wed, 11 May 2022 20:43:14 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E7D5C610A5; Wed, 11 May 2022 20:43:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A9F8C340EE; Wed, 11 May 2022 20:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1652301803; bh=xEM/blzijv5Co5pQRjkedHvSJ+0PM6YfCWj1XIj4ZlQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rpxV0gia6NaJ/rSETbrV1QhlvcpbI6rQ4WC3j/kvlTk8wpxdDQtIV0XN1IdiKxUPp A0Q+IKzDEPf/FGcQlfeJmqf2ZhKSzeddyxPxpXg9wbLQt2D6j6bhCMsHnJjL9S87rd 7WcNtdTnmCRFW14s29jr20QwAF6X5k9lEx8YusMo= Date: Wed, 11 May 2022 13:43:22 -0700 From: Andrew Morton To: Sultan Alsawaf Cc: Minchan Kim , stable@vger.kernel.org, Nitin Gupta , Sergey Senozhatsky , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] zsmalloc: Fix races between asynchronous zspage free and page migration Message-Id: <20220511134322.54c44cb0cdd17a0f7fd9f761@linux-foundation.org> In-Reply-To: References: <20220509024703.243847-1-sultan@kerneltoast.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 4phcyc6h4hknuaqu5799nabmnxpozq5h Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=rpxV0gia; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7F53E1C00A2 X-HE-Tag: 1652301794-877072 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 11 May 2022 12:50:20 -0700 Sultan Alsawaf wrote: > > Shouldn't the fix be Fixes: 77ff465799c6 ("zsmalloc: zs_page_migrate: skip > > unnecessary loops but not return -EBUSY if zspage is not inuse)? > > Because we didn't migrate ZS_EMPTY pages before. > > Hi, > > Yeah, 77ff465799c6 indeed seems like the commit that introduced the bug. I updated the changelog, thanks.