From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9F97C433F5 for ; Wed, 11 May 2022 00:03:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6188F6B0071; Tue, 10 May 2022 20:03:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A1206B0072; Tue, 10 May 2022 20:03:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 451596B0073; Tue, 10 May 2022 20:03:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2EE166B0071 for ; Tue, 10 May 2022 20:03:56 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EEE27210AC for ; Wed, 11 May 2022 00:03:55 +0000 (UTC) X-FDA: 79451514030.15.61EF460 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf01.hostedemail.com (Postfix) with ESMTP id CB2B8400A6 for ; Wed, 11 May 2022 00:03:43 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 00FFAB80E7B; Wed, 11 May 2022 00:03:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEF03C385CC; Wed, 11 May 2022 00:03:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652227432; bh=D/PLmHe0Zv3XheUzevz5zG1/nRmA8yHnhXCml3/8gkg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EddLpvy7HeOKm5EzULh0Ier9AwMnU0HS2Bu8QyfZHXoKsRtaMcGBmbglQfQF25liJ xlFgK5bzN32RGDZZC3xqvZlSmz3mThbkM2pGSjABwYp2uChHhc4KufDkTu+MUqlgPT Vm205PemxYt0euqESK17v4vPq4QooA6dFnk6gwb2WYsonhjbWTXaXbBrg3zMm/4OCQ UEXjyrBAVbLJoooI5BaOPX1eFesaZT3jpFyFGqqmMRRIRFLBCiBhx4OHYJ9s/JjPH+ hW3e5hEmpiRxDnQ/fyoHY1MEfxEK7DddUXSTo6kSnlDtF4SimRk11XqyFpvmp13lp9 GBXtnwbSkO+Iw== Date: Tue, 10 May 2022 17:03:52 -0700 From: "Darrick J. Wong" To: Shiyang Ruan Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, dan.j.williams@intel.com, david@fromorbit.com, hch@infradead.org, jane.chu@oracle.com, rgoldwyn@suse.de, viro@zeniv.linux.org.uk, willy@infradead.org, naoya.horiguchi@nec.com, linmiaohe@huawei.com Subject: Re: [PATCHSETS] v14 fsdax-rmap + v11 fsdax-reflink Message-ID: <20220511000352.GY27195@magnolia> References: <20220508143620.1775214-1-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220508143620.1775214-1-ruansy.fnst@fujitsu.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CB2B8400A6 X-Stat-Signature: nckcknbtwde6he91n1e8mbaop4jhu7fq X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EddLpvy7; spf=pass (imf01.hostedemail.com: domain of djwong@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1652227423-863659 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, May 08, 2022 at 10:36:06PM +0800, Shiyang Ruan wrote: > This is a combination of two patchsets: > 1.fsdax-rmap: https://lore.kernel.org/linux-xfs/20220419045045.1664996-1-ruansy.fnst@fujitsu.com/ > 2.fsdax-reflink: https://lore.kernel.org/linux-xfs/20210928062311.4012070-1-ruansy.fnst@fujitsu.com/ > > Changes since v13 of fsdax-rmap: > 1. Fixed mistakes during rebasing code to latest next- > 2. Rebased to next-20220504 > > Changes since v10 of fsdax-reflink: > 1. Rebased to next-20220504 and fsdax-rmap > 2. Dropped a needless cleanup patch: 'fsdax: Convert dax_iomap_zero to > iter model' > 3. Fixed many conflicts during rebasing > 4. Fixed a dedupe bug in Patch 05: the actuall length to compare could be > shorter than smap->length or dmap->length. > PS: There are many changes during rebasing. I think it's better to > review again. > > == > Shiyang Ruan (14): > fsdax-rmap: > dax: Introduce holder for dax_device > mm: factor helpers for memory_failure_dev_pagemap > pagemap,pmem: Introduce ->memory_failure() > fsdax: Introduce dax_lock_mapping_entry() > mm: Introduce mf_dax_kill_procs() for fsdax case Hmm. This patchset touches at least the dax, pagecache, and xfs subsystems. Assuming it's too late for 5.19, how should we stage this for 5.20? I could just add the entire series to iomap-5.20-merge and base the xfs-5.20-merge off of that? But I'm not sure what else might be landing in the other subsystems, so I'm open to input. --D > xfs: Implement ->notify_failure() for XFS > fsdax: set a CoW flag when associate reflink mappings > fsdax-reflink: > fsdax: Output address in dax_iomap_pfn() and rename it > fsdax: Introduce dax_iomap_cow_copy() > fsdax: Replace mmap entry in case of CoW > fsdax: Add dax_iomap_cow_copy() for dax zero > fsdax: Dedup file range to use a compare function > xfs: support CoW in fsdax mode > xfs: Add dax dedupe support > > drivers/dax/super.c | 67 +++++- > drivers/md/dm.c | 2 +- > drivers/nvdimm/pmem.c | 17 ++ > fs/dax.c | 398 ++++++++++++++++++++++++++++++------ > fs/erofs/super.c | 13 +- > fs/ext2/super.c | 7 +- > fs/ext4/super.c | 9 +- > fs/remap_range.c | 31 ++- > fs/xfs/Makefile | 5 + > fs/xfs/xfs_buf.c | 10 +- > fs/xfs/xfs_file.c | 9 +- > fs/xfs/xfs_fsops.c | 3 + > fs/xfs/xfs_inode.c | 69 ++++++- > fs/xfs/xfs_inode.h | 1 + > fs/xfs/xfs_iomap.c | 46 ++++- > fs/xfs/xfs_iomap.h | 3 + > fs/xfs/xfs_mount.h | 1 + > fs/xfs/xfs_notify_failure.c | 220 ++++++++++++++++++++ > fs/xfs/xfs_reflink.c | 12 +- > fs/xfs/xfs_super.h | 1 + > include/linux/dax.h | 56 ++++- > include/linux/fs.h | 12 +- > include/linux/memremap.h | 12 ++ > include/linux/mm.h | 2 + > include/linux/page-flags.h | 6 + > mm/memory-failure.c | 257 ++++++++++++++++------- > 26 files changed, 1087 insertions(+), 182 deletions(-) > create mode 100644 fs/xfs/xfs_notify_failure.c > > -- > 2.35.1 > > >