From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24083C433EF for ; Tue, 10 May 2022 04:04:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6378C6B0072; Tue, 10 May 2022 00:04:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BECA6B0073; Tue, 10 May 2022 00:04:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 437676B0074; Tue, 10 May 2022 00:04:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 300A36B0072 for ; Tue, 10 May 2022 00:04:09 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F209E20F12 for ; Tue, 10 May 2022 04:04:08 +0000 (UTC) X-FDA: 79448490576.08.E84B597 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 1E94A800A1 for ; Tue, 10 May 2022 04:03:50 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 23CFC60DE0; Tue, 10 May 2022 04:04:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 748DCC385A6; Tue, 10 May 2022 04:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1652155446; bh=6OF+9C9FRL/t2E9bNeco9SygrOB7dQke1qTazheJwmM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=r+cD5N6bK5cMK3KiBjz/TIE0kRJfxClVYedgOaDY6iruFtbN69I0EnTrs28Odgw2B MPfR9kQZKLh7AzrNokC+xb2QjO4x0B/CskDab9TBGZx07zjP3Yerqr9YNFkFVMGD3p VJh3Vtf4VnZ1h7g0napFf0tAy+VjYNyYdsYerxPc= Date: Mon, 9 May 2022 21:04:04 -0700 From: Andrew Morton To: Baolin Wang Cc: mike.kravetz@oracle.com, catalin.marinas@arm.com, will@kernel.org, songmuchun@bytedance.com, tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.osdn.me, dalias@libc.org, davem@davemloft.net, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 0/3] Fix CONT-PTE/PMD size hugetlb issue when unmapping or migrating Message-Id: <20220509210404.6a43aff15d0d6b3af0741001@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: httu36gzqiptiogwj1is6ztijntmmczm Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=r+cD5N6b; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1E94A800A1 X-HE-Tag: 1652155430-617100 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000048, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 10 May 2022 11:45:57 +0800 Baolin Wang wrote: > Hi, > > Now migrating a hugetlb page or unmapping a poisoned hugetlb page, we'll > use ptep_clear_flush() and set_pte_at() to nuke the page table entry > and remap it, and this is incorrect for CONT-PTE or CONT-PMD size hugetlb > page, It would be helpful to describe why it's wrong. Something like "should use huge_ptep_clear_flush() and huge_ptep_clear_flush() for this purpose"? > which will cause potential data consistent issue. This patch set > will change to use hugetlb related APIs to fix this issue, please find > details in each patch. Thanks. Is a cc:stable needed here? And are we able to identify a target for a Fixes: tag?