linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "lipeifeng@oppo.com" <lipeifeng@oppo.com>
To: akpm <akpm@linux-foundation.org>
Cc: michel <michel@lespinasse.org>,  hughd <hughd@google.com>,
	 linux-mm <linux-mm@kvack.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>,
	 "Barry Song" <21cnbao@gmail.com>,
	 zhangshiming <zhangshiming@oppo.com>,
	 peifengl55 <peifengl55@gmail.com>
Subject: Re: Re: [PATCH] mm: fix align-error when get_addr in unmapped_area_topdown
Date: Mon, 9 May 2022 17:23:02 +0800	[thread overview]
Message-ID: <2022050917212835925916@oppo.com> (raw)
In-Reply-To: <20220507145937.6dbfc036f99addf9342bc5ce@linux-foundation.org>

Hi Andrew:

Thank you for your response.

> > > They caused me some merge issues against mapletree, which I had
> > > resolved.  Mapletree is dropped at present so I set these patches aside
>> > until the next version of the mapletree patches are available.
>>
>> Do we have a definite time for the next available version of the mapletree patches?
 
> I merged v2 a couple of days ago.  It should be in mm-unstable then
> linux-next early next week.

Ok, is "v2 merged" the patch from me?
1. mm-modify-the-method-to-search-addr-in-unmapped_area_topdown.patch added to -mm tree
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-modify-the-method-to-search-addr-in-unmapped_area_topdown.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-modify-the-method-to-search-addr-in-unmapped_area_topdown.patch


2. mm-fix-align-error-when-get_addr-in-unmapped_area_topdown.patch added to -mm tree
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-fix-align-error-when-get_addr-in-unmapped_area_topdown.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-fix-align-error-when-get_addr-in-unmapped_area_topdown.patch


> > Excuse me, is it possible for our patch to be independent of mapletree and brought in separately?
 
> Well, the changelog was rather unclear on the real-world end-user
> visible effects of the defect.  When these prioritization decisions are
> to be made, it really helps to have a clear view of the impact to our
> users.

Well, we had found that some apps-crash(TIF_32BIT) due to "Out of memory",  which the single largest remaining
free-addr-space is 12Mbytes in some case, we found that the processes wound fail to alloc
a 12Mbytes(align 1M) in the old methods so that Out-of-Memory.
such as Wechat and others Android apps.

> >
> > > I've been holding your patches until Michel Lespinasse has had time to
> > > review them (and hopefully explain them to me ;)).  Please review
> > > earlier comments which Michel has provided and ensure that those
> > > comments have been fully addressed so we can hopefully move forward on
> > > this.
> >
> > We will reply soon if Mr.Lespinasse provideds any advices or question.
> > And I haven't received any reply from Mr.Lespinasse yet, pls let me know
> > if i missed the reply.
>
> There was a big conference last week.

I missed it and if there any problems about the patches which need me to answer,
pls let me know and i hope i can give a clear reply.

Thank you very much indeed.

lipeifeng@oppo.com
 
From: Andrew Morton
Date: 2022-05-08 05:59
To: lipeifeng@oppo.com
CC: michel; hughd; linux-mm; linux-kernel; Barry Song; zhangshiming; peifengl55
Subject: Re: [PATCH] mm: fix align-error when get_addr in unmapped_area_topdown
On Mon, 2 May 2022 11:33:18 +0800 "lipeifeng@oppo.com" <lipeifeng@oppo.com> wrote:
 
> Hi Andrew:
>
> Thanks for your quick response.
>
> > They caused me some merge issues against mapletree, which I had
> > resolved.  Mapletree is dropped at present so I set these patches aside
> > until the next version of the mapletree patches are available.
>
> Do we have a definite time for the next available version of the mapletree patches?
 
I merged v2 a couple of days ago.  It should be in mm-unstable then
linux-next early next week.
 
> Excuse me, is it possible for our patch to be independent of mapletree and brought in separately?
 
Well, the changelog was rather unclear on the real-world end-user
visible effects of the defect.  When these prioritization decisions are
to be made, it really helps to have a clear view of the impact to our
users.
 
>
> > I've been holding your patches until Michel Lespinasse has had time to
> > review them (and hopefully explain them to me ;)).  Please review
> > earlier comments which Michel has provided and ensure that those
> > comments have been fully addressed so we can hopefully move forward on
> > this.
>
> We will reply soon if Mr.Lespinasse provideds any advices or question.
> And I haven't received any reply from Mr.Lespinasse yet, pls let me know
> if i missed the reply.
 
There was a big conference last week.

  reply	other threads:[~2022-05-09  9:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12  8:10 lipeifeng
2022-04-12 21:22 ` Andrew Morton
2022-04-13  3:28   ` lipeifeng
2022-05-01  2:26     ` lipeifeng
2022-05-02  1:10       ` Andrew Morton
     [not found]         ` <2022050211305415626916@oppo.com>
2022-05-07 21:59           ` Andrew Morton
2022-05-09  9:23             ` lipeifeng [this message]
2022-05-09 11:45           ` Michel Lespinasse
     [not found]             ` <2022051610294089439420@oppo.com>
2022-05-16  7:45               ` Michel Lespinasse
2022-05-17  8:04                 ` lipeifeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2022050917212835925916@oppo.com \
    --to=lipeifeng@oppo.com \
    --cc=21cnbao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=michel@lespinasse.org \
    --cc=peifengl55@gmail.com \
    --cc=zhangshiming@oppo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox