From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E99A3C433F5 for ; Mon, 9 May 2022 18:04:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01F1B6B0072; Mon, 9 May 2022 14:04:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0FD26B0073; Mon, 9 May 2022 14:03:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFF2D6B0074; Mon, 9 May 2022 14:03:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D17AA6B0072 for ; Mon, 9 May 2022 14:03:59 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A945F31227 for ; Mon, 9 May 2022 18:03:59 +0000 (UTC) X-FDA: 79446978198.10.2699089 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 3AA24400A4 for ; Mon, 9 May 2022 18:03:48 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2E9E5615D8; Mon, 9 May 2022 18:03:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B90FC385B4; Mon, 9 May 2022 18:03:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1652119437; bh=RCqR7E+e88v1T6AamGxBpGhIcGsy4V7gM+0oan8ZkAs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Nc4O4PAMi8KjdjcpLV2zwGCVhL+a5FMfOdLsSBppvNtCRmUFWTooI0FQ3MmqTGRzJ vhVa8CGKwPA0MXtJr7w4nmmW7ichDCxqXahhZapcWgE2rkfNPZDW1EBTclw10XRcQ3 Rh18x3oQfQHKYwOoRkzkv9HDn25eowcuD0JixPVA= Date: Mon, 9 May 2022 11:03:56 -0700 From: Andrew Morton To: Tom Rix Cc: hughd@google.com, nathan@kernel.org, ndesaulniers@google.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] mm/shmem: restore setting of page variable Message-Id: <20220509110356.3c1826c6bf1fd6a4d6ce6766@linux-foundation.org> In-Reply-To: <20220509123232.3428667-1-trix@redhat.com> References: <20220509123232.3428667-1-trix@redhat.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3AA24400A4 X-Stat-Signature: raqgx7c43unbuxo5x1r33aiyesunu4yk X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Nc4O4PAM; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1652119428-331740 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 9 May 2022 08:32:32 -0400 Tom Rix wrote: > The clang build fails with > mm/shmem.c:2337:8: error: variable 'page' is uninitialized when used here [-Werror,-Wuninitialized] > if (!page) > ^~~~ > > In the commit listed in the fixes, there was a change to the > from > page = shmem_alloc_page(..); > to > page = &shmem_alloc_folio(..)->page; > But in this case, instead of replacing, the setting of page was > deleted. So restore page with its new api. > > ... > > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -2334,6 +2334,7 @@ int shmem_mfill_atomic_pte(struct mm_struct *dst_mm, > > if (!*pagep) { > ret = -ENOMEM; > + page = &shmem_alloc_folio(gfp, info, pgoff)->page; > if (!page) > goto out_unacct_blocks; > Thanks, this is fixed in v2 of Matthew's "Folio patches for 5.19" series. I've just now pushed all that out to kernel.org so next linux-next should be a happier place.