From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02A18C433F5 for ; Mon, 9 May 2022 07:19:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FDE46B0071; Mon, 9 May 2022 03:19:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AD926B0073; Mon, 9 May 2022 03:19:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C4396B0074; Mon, 9 May 2022 03:19:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5BD1A6B0071 for ; Mon, 9 May 2022 03:19:40 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 3A684809E1 for ; Mon, 9 May 2022 07:19:40 +0000 (UTC) X-FDA: 79445354520.17.EB54062 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 55274C0089 for ; Mon, 9 May 2022 07:19:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Ty1AgeIKh2EYFgs2k2ZbylGJHiYAUJfCHKZ+rmSmMaQ=; b=RoAnqLNllKj1hmkegOm01Xrm+D Cz0Tx3zj9aXC2bt73QRpqQYKllmFeswOUAvhK1nxKrs+IgAKwTfx+2dUKy1M0VPPsLfFeClcMayiZ C1ZNRWpY/BpppfQ93+0f9aQ4oSMXHAH8GQZzYcvXko90t8A9EI9jKAIhzXqhfXYI5AkuO4vLo9nhv SmSnnmoEF6Llw8DtgVnwb8sJjhFM54P9/lfGkqF1qfQDcKXSfOE95/VxDY3xrUeKNcFroU2fjVOQb xCtJv8/ws76Ez9CtCEirvWoSjtwUmjT8oIs6a3GxmL14Z2SGfXy8DN9qa71hMYS7/SRTsmwFt1lBg ohsuZp1A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnxfx-003E3h-2F; Mon, 09 May 2022 07:19:25 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 391D9980E93; Mon, 9 May 2022 09:19:24 +0200 (CEST) Date: Mon, 9 May 2022 09:19:24 +0200 From: Peter Zijlstra To: Li kunyu Cc: dave.hansen@linux.intel.com, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: Functions may simplify the use of return values Message-ID: <20220509071924.GF76023@worktop.programming.kicks-ass.net> References: <20220507150630.90399-1-kunyu@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220507150630.90399-1-kunyu@nfschina.com> X-Stat-Signature: hm891zrnrxskscd1gr54f5gaf7ejhoc1 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 55274C0089 X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=RoAnqLNl; dmarc=none; spf=none (imf28.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org X-HE-Tag: 1652080760-435528 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 07, 2022 at 11:06:30PM +0800, Li kunyu wrote: > p4d_clear_huge may be optimized for void return type and function usage. > vunmap_p4d_range function saves a few steps here. This makes it different from all the other p??_clear_huge() functions, which seems like an exceedingly bad idea.