From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B1BDC433EF for ; Sat, 7 May 2022 20:15:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94BD76B0071; Sat, 7 May 2022 16:15:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D3136B0073; Sat, 7 May 2022 16:15:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74CFA6B0074; Sat, 7 May 2022 16:15:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5FF186B0071 for ; Sat, 7 May 2022 16:15:13 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3D1B22EA0C for ; Sat, 7 May 2022 20:15:13 +0000 (UTC) X-FDA: 79440051306.23.95FA4D1 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf14.hostedemail.com (Postfix) with ESMTP id EFA46100009 for ; Sat, 7 May 2022 20:15:10 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6E319B8015B; Sat, 7 May 2022 20:15:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1BFFC385A6; Sat, 7 May 2022 20:15:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651954510; bh=vy1aTQRyTt6mm1Fciyw9fxZa5j08wtLtUivP/CPXaw4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HN9ADlsGpl4HGsRRNrNXHM0KLz5DLENt4xIO8fDLvSspVbIVqLC8KUvhKNCtkX1X4 D+6r3SrryyIDopT/IdvoVS3zxdIpNnrXrHGt8wgXl2lPBrzHDFIXF/SKOJMArRSxkD GGdT8bPiLKpo3FV1087u9Qf0CN2Ex4/qWqZtJUU0F2NLK7Y15PI9oKV4axf1aSKnV9 dDz2Q3LYiiWDEOJcaxd1FpBwCLbQh2KVCtzYl9Yb4Mqxa/ZQ7q3jaNhfejDUCPPH4A vqXh92WhDvy1suM/LE7B0tb2qfbY2gpX1I+7nAHqxRWqifIjp5qrLrPNt5Oh8mLN5f aWYnpY2bMn30w== From: SeongJae Park To: Gautam Menghani Cc: sj@kernel.org, skhan@linuxfoundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Add documentation for Enum value 'NR_DAMON_OPS' in Date: Sat, 7 May 2022 20:15:07 +0000 Message-Id: <20220507201507.46050-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220507165620.110706-1-gautammenghani201@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: odwdtx9ghgnhgpdayjr7ui9fc1xax9fz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EFA46100009 X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HN9ADlsG; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org X-HE-Tag: 1651954510-848829 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Gautam, On Sat, 7 May 2022 22:26:20 +0530 Gautam Menghani wrote: > Fix the warning - "Enum value 'NR_DAMON_OPS' not described in > enum 'damon_ops_id'" generated by the command "make pdfdocs" > > Signed-off-by: Gautam Menghani > --- > Changes in v2: > - Fix checkpatch warning of 75 characters per line > - Fix email mismatch in from and signed by field Thank you for the fix, but please read below. Could you please adjust the subject so that we can know for what subsystem this change is made? E.g., mm/damon: Add documentation for ... > > include/linux/damon.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/damon.h b/include/linux/damon.h > index f23cbfa4248d..b972a7a3b6f0 100644 > --- a/include/linux/damon.h > +++ b/include/linux/damon.h > @@ -262,6 +262,7 @@ struct damos { > * > * @DAMON_OPS_VADDR: Monitoring operations for virtual address spaces > * @DAMON_OPS_PADDR: Monitoring operations for the physical address space > + * @NR_DAMON_OPS: Number of monitoring operations for a particular implementation My previous comment to this part seems not answered? I'd suggest 's/for a particular implementation/implementations/' Thanks, SJ > */ > enum damon_ops_id { > DAMON_OPS_VADDR, > -- > 2.25.1 >