From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2147C433F5 for ; Sat, 7 May 2022 23:00:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E131B6B0071; Sat, 7 May 2022 19:00:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBFC56B0073; Sat, 7 May 2022 19:00:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C89706B0074; Sat, 7 May 2022 19:00:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B7E746B0071 for ; Sat, 7 May 2022 19:00:15 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 78E20209C0 for ; Sat, 7 May 2022 23:00:15 +0000 (UTC) X-FDA: 79440467190.28.BECD22F Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf27.hostedemail.com (Postfix) with ESMTP id CC36D40081 for ; Sat, 7 May 2022 23:00:12 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 18394B80CCC; Sat, 7 May 2022 23:00:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CB06C385A6; Sat, 7 May 2022 23:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1651964411; bh=PI9YBhyJ05Qj2TBmHJYBGR+TzRijgTsKpsKyP8FRIm4=; h=Date:From:To:Subject:In-Reply-To:References:From; b=CICA6/dE7xyVPrJbWnCv0QxiptoChazOuu4BdQswqsjmKRcNEZ+Y+JHjBEX6q9TPy VUuDDu8BMKXRYwi5kx2MTW9Ol8k8XkdHXY+/z7JYNBi0yw2CU7qcvNIKkjAklnXZu2 jRnW7uS4dnO+5IvcTZmNXf8l9GSwIYyAT441XZzs= Date: Sat, 7 May 2022 16:00:10 -0700 From: Andrew Morton To: Vasily Averin , Steven Rostedt , Ingo Molnar , kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH mm] tracing: incorrect gfp_t conversion Message-Id: <20220507160010.aa2077e28c4710400e144bfb@linux-foundation.org> In-Reply-To: <20220507154835.4d4d737d8eed579969f15938@linux-foundation.org> References: <331d88fe-f4f7-657c-02a2-d977f15fbff6@openvz.org> <20220507123728.f20d977eba9fbb66bddee722@linux-foundation.org> <8b1cfefa-da7d-3376-cf04-1ff77dab8170@openvz.org> <20220507154835.4d4d737d8eed579969f15938@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="CICA6/dE"; dmarc=none; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CC36D40081 X-Rspam-User: X-Stat-Signature: x79u19wg8u34tgw6kzn6fxw87cunpt96 X-HE-Tag: 1651964412-922251 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 7 May 2022 15:48:35 -0700 Andrew Morton wrote: > I did the below. > Silly me, doesn't work. > > --- a/include/trace/events/mmflags.h~tracing-incorrect-gfp_t-conversion-fix > +++ a/include/trace/events/mmflags.h > @@ -13,53 +13,57 @@ > * Thus most bits set go first. > */ > > +#define FUL __force unsigned long > + > #define __def_gfpflag_names \ > - {(__force unsigned long)GFP_TRANSHUGE, "GFP_TRANSHUGE"}, \ Can't expand FUL here within the macro definition.