From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 973ECC433EF for ; Sat, 7 May 2022 15:52:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBB856B0071; Sat, 7 May 2022 11:52:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6A636B0073; Sat, 7 May 2022 11:52:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D32196B0074; Sat, 7 May 2022 11:52:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C42206B0071 for ; Sat, 7 May 2022 11:52:31 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 930132C0E6 for ; Sat, 7 May 2022 15:52:31 +0000 (UTC) X-FDA: 79439389302.04.154430C Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf15.hostedemail.com (Postfix) with ESMTP id 905CBA0080 for ; Sat, 7 May 2022 15:52:20 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 1B12ACE0176; Sat, 7 May 2022 15:52:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C91CDC385A6; Sat, 7 May 2022 15:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651938746; bh=2SWYDipD6SESlBoUy8Z+tftQJmKG5uu41ZRc1VgASEo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fHsksQv5r2lJ5k6ESJwvLIO22YzQe9zfKdNo+5iPKDSjyokVTGA6Jg3uhZou7Lqdh zKdroGbEFcRWQzC4khiNg1GRBpQKAtCAzOukP7pmgLO3qwrkbpNyB5nI/AHo1V12W3 2OvUnfHwZoyyJkEeprgJPbU7KoY+VNbXGkBw8mxFrefziwc5mOPlzTq2Azbg7xcT/c wWYva+KXRAr1mLeJcg7yA7bX1HPEja2ukkt1VybsgMoAxsACvfMfUjNDYOeoLVG18E +KwJT9RG1ixaawWYnzEAim7rkbuyjzoY9JU4dAgsIk5tzXS/4qzgWdvQD0ZFh83tkc rK4oHEWxHvOkg== From: SeongJae Park To: Gautam Menghani Cc: sj@kernel.org, skhan@linuxfoundation.org, Gautam Menghani , linux-mm@kvack.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH] Add documentation for Enum value 'NR_DAMON_OPS' in enum 'damon_ops_id' Date: Sat, 7 May 2022 15:52:18 +0000 Message-Id: <20220507155218.45706-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220507070850.14150-1-gautammenghani201@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 905CBA0080 X-Stat-Signature: 1sgdtr1bewjppizoy81abj5i468phr3x X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fHsksQv5; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam09 X-HE-Tag: 1651938740-951566 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Gautam, Thank you for the patch. 'checkpatch.pl' complains as below, though: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #12: Fix the warning - "Enum value 'NR_DAMON_OPS' not described in enum 'damon_ops_id'" generated by the command "make pdfdocs" WARNING: From:/Signed-off-by: email address mismatch: 'From: Gautam Menghani ' != 'Signed-off-by: Gautam Menghani ' total: 0 errors, 2 warnings, 7 lines checked Could you please fix those? On Sat, 7 May 2022 12:38:50 +0530 Gautam Menghani wrote: > From: Gautam Menghani > > Fix the warning - "Enum value 'NR_DAMON_OPS' not described in enum 'damon_ops_id'" generated by the command "make pdfdocs" > > Signed-off-by: Gautam Menghani > --- > include/linux/damon.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/damon.h b/include/linux/damon.h > index f23cbfa4248d..b972a7a3b6f0 100644 > --- a/include/linux/damon.h > +++ b/include/linux/damon.h > @@ -262,6 +262,7 @@ struct damos { > * > * @DAMON_OPS_VADDR: Monitoring operations for virtual address spaces > * @DAMON_OPS_PADDR: Monitoring operations for the physical address space > + * @NR_DAMON_OPS: Number of monitoring operations for a particular implementation I'd like to keep the 80 column limit[1]. [1] https://docs.kernel.org/process/coding-style.html#breaking-long-lines-and-strings Also, strictly speaking, it's not the number of monitoring operations for _a particular implementation_, but 'number of monitoring operations implementations'. And it's shorter. How about the suggestion? Thanks, SJ > */ > enum damon_ops_id { > DAMON_OPS_VADDR, > -- > 2.25.1