From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B3BAC433F5 for ; Sat, 7 May 2022 21:05:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C98396B0071; Sat, 7 May 2022 17:05:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C47EA6B0073; Sat, 7 May 2022 17:05:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0F0A6B0074; Sat, 7 May 2022 17:05:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A18F36B0071 for ; Sat, 7 May 2022 17:05:11 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 86A3C20977 for ; Sat, 7 May 2022 21:05:11 +0000 (UTC) X-FDA: 79440177222.08.8667C8E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 9EA9CA005A for ; Sat, 7 May 2022 21:05:00 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 303E560F1B; Sat, 7 May 2022 21:05:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BB80C385A5; Sat, 7 May 2022 21:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1651957509; bh=qYJf6KKIw0kS7h3klkpFrLBCOJEdBYsXoDnCkBbFot8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qxP2AP0lq9d2eXVJ8PA6dz/JiOL9xsmVaaf1clt+8Ad5mfECqtsRZDb9a5dBiJQfk SOPlgf7msLNc6PhcyaPgxTLCMEI2KQvWbOUGRd333UnGei+mEEUTt2Mr9Bhbe35wXy ee82ymIYse7stEUwRtebn8IQ76nJwnQD48BCeWck= Date: Sat, 7 May 2022 14:05:08 -0700 From: Andrew Morton To: Muchun Song Cc: Mike Kravetz , corbet@lwn.net, mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com, osalvador@suse.de, david@redhat.com, masahiroy@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, smuchun@gmail.com Subject: Re: [PATCH v9 2/4] mm: memory_hotplug: override memmap_on_memory when hugetlb_free_vmemmap=on Message-Id: <20220507140508.38c9e211eae4715134f9fa31@linux-foundation.org> In-Reply-To: References: <20220429121816.37541-1-songmuchun@bytedance.com> <20220429121816.37541-3-songmuchun@bytedance.com> <3d040faf-7fc1-80a6-c584-aafeff27af18@oracle.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: gp4gpgqqn5s8i5cp33mbf9qfpd8oi1ys X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9EA9CA005A Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=qxP2AP0l; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-HE-Tag: 1651957500-362890 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 4 May 2022 11:37:43 +0800 Muchun Song wrote: > > Freeing HugeTLB vmemmap pages is not compatible with allocating memmap on > > hot added memory. If "hugetlb_free_vmemmap=on" and > > memory_hotplug.memmap_on_memory" are both passed on the kernel command line, > > freeing hugetlb pages takes precedence. However, the global variable > > memmap_on_memory will still be set to 1, even though we will not try to > > allocate memmap on hot added memory. > > > > Not sure if that is more clear or not. > > > > Clearer than mine. I updated, thanks.